From: Emil Medve <Emilian.Medve@Freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: scottwood@Freescale.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3] powerpc: Use PFN_PHYS() to avoid truncating the physical address
Date: Thu, 26 Mar 2015 10:31:22 -0500 [thread overview]
Message-ID: <5514264A.6020502@Freescale.com> (raw)
In-Reply-To: <FB8A0580-9A76-4F83-BDE7-2EECC0063C1C@kernel.crashing.org>
Hello Kumar,
On 03/26/2015 10:18 AM, Kumar Gala wrote:
> Why no commit message with what issue this change was trying to fix?
A while back, when I attempted to remove bootmem (in favor of just plain
memblock as in powerpc land bootmem was just a wrapper to memblock
anyway) I run at some point into a problem with an intermediate address
value because of this '<< PAGE_SHIFT' on the wrong width variable. Using
PFN_PHYS() took care of it (it has a cast) so I decided to get this
defensive patch applied. Since, I dropped my bootmem/memblock patches in
favor to Anton's (Blanchard) work so my concrete issue example is
somewhat gone
Cheers,
> - k
>
> On Mar 25, 2015, at 8:49 AM, Emil Medve <Emilian.Medve@freescale.com> wrote:
>
>> Signed-off-by: Emil Medve <Emilian.Medve@Freescale.com>
>> ---
>>
>> v3: Rebased and updated due to upstream changes since v2
>>
>> v2: Rebased and updated due to upstream changes since v1
>>
>> arch/powerpc/include/asm/io.h | 2 +-
>> arch/powerpc/include/asm/page.h | 2 +-
>> arch/powerpc/include/asm/pgalloc-32.h | 2 +-
>> arch/powerpc/include/asm/rtas.h | 3 ++-
>> arch/powerpc/kernel/crash_dump.c | 2 +-
>> arch/powerpc/kernel/eeh.c | 4 +---
>> arch/powerpc/kernel/io-workarounds.c | 2 +-
>> arch/powerpc/kernel/pci-common.c | 2 +-
>> arch/powerpc/kernel/vdso.c | 6 +++---
>> arch/powerpc/kvm/book3s_64_mmu_host.c | 2 +-
>> arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +-
>> arch/powerpc/kvm/book3s_hv_rm_mmu.c | 4 ++--
>> arch/powerpc/kvm/e500_mmu_host.c | 5 ++---
>> arch/powerpc/mm/hugepage-hash64.c | 2 +-
>> arch/powerpc/mm/hugetlbpage-book3e.c | 2 +-
>> arch/powerpc/mm/hugetlbpage-hash64.c | 2 +-
>> arch/powerpc/mm/mem.c | 9 ++++-----
>> arch/powerpc/mm/numa.c | 5 ++---
>> arch/powerpc/platforms/powernv/opal.c | 2 +-
>> arch/powerpc/platforms/pseries/iommu.c | 8 ++++----
>> 20 files changed, 32 insertions(+), 36 deletions(-)
next prev parent reply other threads:[~2015-03-26 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 13:49 [PATCH v3] powerpc: Use PFN_PHYS() to avoid truncating the physical address Emil Medve
2015-03-26 15:18 ` Kumar Gala
2015-03-26 15:31 ` Emil Medve [this message]
2015-03-26 23:45 ` Michael Ellerman
2015-03-27 18:07 ` Scott Wood
2015-03-30 1:40 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5514264A.6020502@Freescale.com \
--to=emilian.medve@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@Freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).