linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Linux PPC dev <linuxppc-dev@ozlabs.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: "ak@linux.intel.com" <ak@linux.intel.com>,
	Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Michael Ellerman <michaele@au1.ibm.com>
Subject: perf report broken for branch stack samples
Date: Wed, 01 Apr 2015 14:32:54 +0530	[thread overview]
Message-ID: <551BB43E.5070600@linux.vnet.ibm.com> (raw)

Hello,

perf report is not showing up the branch stack sample results in the
from_symbol ---> to_symbol format even if the perf.data file has got
the samples (through 'perf record -b <workload>' session). Perf report
still displays the generic event based relative symbol classification
as usual. This problem can also be seen on X86. I wonder whether there
is any semantics change in the way perf report auto detects branch stack
samples in the perf.data file and reports in the intended format. After
doing a git bisect session, this following commit seems to have changed
the  perf report behavior.

commit fa94c36c29ed8bb4749b5fd7ea51a593f673dcef
Author: Andi Kleen <ak@linux.intel.com>
Date:   Wed Nov 12 18:05:22 2014 -0800

    perf report: Add --branch-history option
    
    Add a --branch-history option to perf report that changes all the
    settings necessary for using the branches in callstacks.
    
    This is just a short cut to make this nicer to use, it does not enable
    any functionality by itself.
    
    v2: Change sort order. Rename option to --branch-history to
        be less confusing.
    v3: Updates
    v4: Fix conflict with newer perf base
    v5: Port to latest tip
    v6: Add more comments. Remove CCKEY_ADDRESS setting. Remove
        unnecessary branch_mode setting. Use a boolean.
    
    Signed-off-by: Andi Kleen <ak@linux.intel.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Link: http://lkml.kernel.org/r/1415844328-4884-5-git-send-email-andi@firstfloor.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

I dont have much context of this change but it seems to be using branch
records along with call chain data (provided you have used both -b/-j
and -g option during perf record) to display better control flow graph ?
But then if we have just used -b and not -g then it should still give us
the previous output what we used to get.

Regards
Anshuman

             reply	other threads:[~2015-04-01  9:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01  9:02 Anshuman Khandual [this message]
2015-04-06 23:35 ` perf report broken for branch stack samples Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551BB43E.5070600@linux.vnet.ibm.com \
    --to=khandual@linux.vnet.ibm.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=michaele@au1.ibm.com \
    --cc=sukadev@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).