From: leroy christophe <christophe.leroy@c-s.fr>
To: Scott Wood <scottwood@freescale.com>
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: powerpc32: fix warning from include/linux/mm.h
Date: Tue, 07 Apr 2015 10:07:58 +0200 [thread overview]
Message-ID: <5523905E.6050007@c-s.fr> (raw)
In-Reply-To: <20150320235213.GA1233@home.buserror.net>
Le 21/03/2015 00:52, Scott Wood a écrit :
> On Fri, Dec 05, 2014 at 12:20:20PM +0100, LEROY Christophe wrote:
>> include/linux/mm.h: In function 'is_vmalloc_addr':
>> include/linux/mm.h:367:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
>> return addr >= VMALLOC_START && addr < VMALLOC_END;
>> ^
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>> ---
>> arch/powerpc/include/asm/pgtable-ppc32.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
> That warning doesn't appear to be enabled. What config are you seeing
> this with?
I'm used to adding EXTRA_CFLAGS=-Wextra when checking my own drivers,
as it helps finding additional bugs.
When doing that, the only warnings I get outside of my own code are this
one, and the other one in my proposed patch identified "powerpc32: fix
warning from include/asm-generic/termios-base.h"
I though it would be worth fixing those two warnings in order to get a
perfectly clean code.
Christophe
next prev parent reply other threads:[~2015-04-07 8:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 11:20 [PATCH] powerpc32: fix warning from include/linux/mm.h Christophe Leroy
2015-03-20 23:52 ` Scott Wood
2015-04-07 8:07 ` leroy christophe [this message]
2015-04-07 21:19 ` Scott Wood
2015-04-08 3:27 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5523905E.6050007@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).