From: leroy christophe <christophe.leroy@c-s.fr>
To: David Laight <David.Laight@ACULAB.COM>,
Kim Phillips <kim.phillips@freescale.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
David S Miller <davem@davemloft.net>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH v3 03/17] crypto: talitos - talitos_ptr renamed ptr for more lisibility
Date: Fri, 17 Apr 2015 18:25:55 +0200 [thread overview]
Message-ID: <55313413.2050604@c-s.fr> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CB21235@AcuExch.aculab.com>
Le 17/04/2015 17:14, David Laight a écrit :
> From: Christophe Leroy
>> Linux CodyingStyle recommends to use short variables for local
>> variables. ptr is just good enough for those 3 lines functions.
>> It helps keep single lines shorter than 80 characters.
> ...
>> -static void to_talitos_ptr(struct talitos_ptr *talitos_ptr, dma_addr_t dma_addr)
>> +static void to_talitos_ptr(struct talitos_ptr *ptr, dma_addr_t dma_addr)
>> {
>> - talitos_ptr->ptr = cpu_to_be32(lower_32_bits(dma_addr));
>> - talitos_ptr->eptr = upper_32_bits(dma_addr);
>> + ptr->ptr = cpu_to_be32(lower_32_bits(dma_addr));
>> + ptr->eptr = upper_32_bits(dma_addr);
>> }
> ...
>
> Maybe, but 'ptr' isn't a good choice.
>
>
Any suggestion ?
Christophe
next prev parent reply other threads:[~2015-04-17 16:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 14:24 [PATCH v3 03/17] crypto: talitos - talitos_ptr renamed ptr for more lisibility Christophe Leroy
2015-04-17 15:14 ` David Laight
2015-04-17 16:25 ` leroy christophe [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-04-17 14:31 Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55313413.2050604@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kim.phillips@freescale.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).