linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Shreyas B Prabhu <shreyas@linux.vnet.ibm.com>
To: mpe@ellerman.id.au, agraf@suse.de
Cc: ego@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kvm: powerpc: Fix ppc64_defconfig + PPC_POWERNV=n build error
Date: Thu, 23 Apr 2015 10:11:31 +0530	[thread overview]
Message-ID: <553877FB.4040507@linux.vnet.ibm.com> (raw)
In-Reply-To: <1429181889-1448-1-git-send-email-shreyas@linux.vnet.ibm.com>

Any suggestions on this?

On Thursday 16 April 2015 04:28 PM, Shreyas B. Prabhu wrote:
> kvm_no_guest function calls power7_wakeup_loss to put the thread into
> the deepest supported idle state. power7_wakeup_loss is defined in
> arch/powerpc/kernel/idle_power7.S, which is compiled only when PPC_P7_NAP=y.
> And PPC_P7_NAP is selected when PPC_POWERNV=y.
> Hence in cases where PPC_POWERNV=n and KVM_BOOK3S_64_HV=y we see the
> following error:
> 
> arch/powerpc/kvm/built-in.o: In function `kvm_no_guest':
> arch/powerpc/kvm/book3s_hv_rmhandlers.o:(.text+0x42c): undefined reference to `power7_wakeup_loss'
> 
> Fix this by adding PPC_POWERNV as a dependency for KVM_BOOK3S_64_HV.
> 
> Signed-off-by: Shreyas B. Prabhu <shreyas@linux.vnet.ibm.com>
> ---
>  arch/powerpc/kvm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
> index 11850f3..b3b3d9f 100644
> --- a/arch/powerpc/kvm/Kconfig
> +++ b/arch/powerpc/kvm/Kconfig
> @@ -75,7 +75,7 @@ config KVM_BOOK3S_64
> 
>  config KVM_BOOK3S_64_HV
>  	tristate "KVM support for POWER7 and PPC970 using hypervisor mode in host"
> -	depends on KVM_BOOK3S_64
> +	depends on KVM_BOOK3S_64 && PPC_POWERNV
>  	select KVM_BOOK3S_HV_POSSIBLE
>  	select MMU_NOTIFIER
>  	select CMA
> 

  reply	other threads:[~2015-04-23  4:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-16 10:58 [PATCH] kvm: powerpc: Fix ppc64_defconfig + PPC_POWERNV=n build error Shreyas B. Prabhu
2015-04-23  4:41 ` Shreyas B Prabhu [this message]
2015-04-23  7:24   ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553877FB.4040507@linux.vnet.ibm.com \
    --to=shreyas@linux.vnet.ibm.com \
    --cc=agraf@suse.de \
    --cc=ego@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).