* [PATCH] kvm: powerpc: Fix ppc64_defconfig + PPC_POWERNV=n build error
@ 2015-04-16 10:58 Shreyas B. Prabhu
2015-04-23 4:41 ` Shreyas B Prabhu
0 siblings, 1 reply; 3+ messages in thread
From: Shreyas B. Prabhu @ 2015-04-16 10:58 UTC (permalink / raw)
To: mpe; +Cc: ego, Shreyas B. Prabhu, linuxppc-dev, linux-kernel, agraf
kvm_no_guest function calls power7_wakeup_loss to put the thread into
the deepest supported idle state. power7_wakeup_loss is defined in
arch/powerpc/kernel/idle_power7.S, which is compiled only when PPC_P7_NAP=y.
And PPC_P7_NAP is selected when PPC_POWERNV=y.
Hence in cases where PPC_POWERNV=n and KVM_BOOK3S_64_HV=y we see the
following error:
arch/powerpc/kvm/built-in.o: In function `kvm_no_guest':
arch/powerpc/kvm/book3s_hv_rmhandlers.o:(.text+0x42c): undefined reference to `power7_wakeup_loss'
Fix this by adding PPC_POWERNV as a dependency for KVM_BOOK3S_64_HV.
Signed-off-by: Shreyas B. Prabhu <shreyas@linux.vnet.ibm.com>
---
arch/powerpc/kvm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
index 11850f3..b3b3d9f 100644
--- a/arch/powerpc/kvm/Kconfig
+++ b/arch/powerpc/kvm/Kconfig
@@ -75,7 +75,7 @@ config KVM_BOOK3S_64
config KVM_BOOK3S_64_HV
tristate "KVM support for POWER7 and PPC970 using hypervisor mode in host"
- depends on KVM_BOOK3S_64
+ depends on KVM_BOOK3S_64 && PPC_POWERNV
select KVM_BOOK3S_HV_POSSIBLE
select MMU_NOTIFIER
select CMA
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kvm: powerpc: Fix ppc64_defconfig + PPC_POWERNV=n build error
2015-04-16 10:58 [PATCH] kvm: powerpc: Fix ppc64_defconfig + PPC_POWERNV=n build error Shreyas B. Prabhu
@ 2015-04-23 4:41 ` Shreyas B Prabhu
2015-04-23 7:24 ` Michael Ellerman
0 siblings, 1 reply; 3+ messages in thread
From: Shreyas B Prabhu @ 2015-04-23 4:41 UTC (permalink / raw)
To: mpe, agraf; +Cc: ego, linuxppc-dev, linux-kernel
Any suggestions on this?
On Thursday 16 April 2015 04:28 PM, Shreyas B. Prabhu wrote:
> kvm_no_guest function calls power7_wakeup_loss to put the thread into
> the deepest supported idle state. power7_wakeup_loss is defined in
> arch/powerpc/kernel/idle_power7.S, which is compiled only when PPC_P7_NAP=y.
> And PPC_P7_NAP is selected when PPC_POWERNV=y.
> Hence in cases where PPC_POWERNV=n and KVM_BOOK3S_64_HV=y we see the
> following error:
>
> arch/powerpc/kvm/built-in.o: In function `kvm_no_guest':
> arch/powerpc/kvm/book3s_hv_rmhandlers.o:(.text+0x42c): undefined reference to `power7_wakeup_loss'
>
> Fix this by adding PPC_POWERNV as a dependency for KVM_BOOK3S_64_HV.
>
> Signed-off-by: Shreyas B. Prabhu <shreyas@linux.vnet.ibm.com>
> ---
> arch/powerpc/kvm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
> index 11850f3..b3b3d9f 100644
> --- a/arch/powerpc/kvm/Kconfig
> +++ b/arch/powerpc/kvm/Kconfig
> @@ -75,7 +75,7 @@ config KVM_BOOK3S_64
>
> config KVM_BOOK3S_64_HV
> tristate "KVM support for POWER7 and PPC970 using hypervisor mode in host"
> - depends on KVM_BOOK3S_64
> + depends on KVM_BOOK3S_64 && PPC_POWERNV
> select KVM_BOOK3S_HV_POSSIBLE
> select MMU_NOTIFIER
> select CMA
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-23 7:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-16 10:58 [PATCH] kvm: powerpc: Fix ppc64_defconfig + PPC_POWERNV=n build error Shreyas B. Prabhu
2015-04-23 4:41 ` Shreyas B Prabhu
2015-04-23 7:24 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).