linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Cc: "rlippert@google.com" <rlippert@google.com>,
	"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH V3] cpuidle: Handle tick_broadcast_enter() failure gracefully
Date: Fri, 08 May 2015 13:43:38 +0100	[thread overview]
Message-ID: <554CAF7A.6060609@arm.com> (raw)
In-Reply-To: <20150508073418.28491.4150.stgit@preeti.in.ibm.com>



On 08/05/15 08:35, Preeti U Murthy wrote:
> When a CPU has to enter an idle state where tick stops, it makes a call
> to tick_broadcast_enter(). The call will fail if this CPU is the
> broadcast CPU. Today, under such a circumstance, the arch cpuidle code
> handles this CPU.  This is not convincing because not only do we not
> know what the arch cpuidle code does, but we also do not account for the
> idle state residency time and usage of such a CPU.
>
> This scenario can be handled better by simply choosing an idle state
> where in ticks do not stop. To accommodate this change move the setting
> of runqueue idle state from the core to the cpuidle driver, else the
> rq->idle_state will be set wrong.
>
> Signed-off-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>

I gave it a spin on ARM64 Juno platform with one of the CPU in broadcast
mode and Vexpress TC2 with broadcast timer. I found no issues in both
the cases. So, you can add:

Tested-by: Sudeep Holla <sudeep.holla@arm.com>

Regards,
Sudeep

  reply	other threads:[~2015-05-08 12:43 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08  7:35 [PATCH V3] cpuidle: Handle tick_broadcast_enter() failure gracefully Preeti U Murthy
2015-05-08 12:43 ` Sudeep Holla [this message]
2015-05-08 14:18 ` Rafael J. Wysocki
2015-05-08 21:51   ` Rafael J. Wysocki
2015-05-09  5:49   ` Preeti U Murthy
2015-05-09 18:46     ` Rafael J. Wysocki
2015-05-09 18:48       ` Rafael J. Wysocki
2015-05-09 20:11     ` Rafael J. Wysocki
2015-05-09 20:33       ` Rafael J. Wysocki
2015-05-09 23:15         ` [PATCH 0/3] cpuidle: updates related to tick_broadcast_enter() failures Rafael J. Wysocki
2015-05-09 23:18           ` [PATCH 1/3] sched / idle: Call idle_set_state() from cpuidle_enter_state() Rafael J. Wysocki
2015-05-09 23:18           ` [PATCH 2/3] sched / idle: Call default_idle_call() " Rafael J. Wysocki
2015-05-09 23:19           ` [PATCH 3/3] cpuidle: Select a different state on tick_broadcast_enter() failures Rafael J. Wysocki
2024-08-21  9:51             ` Dhruva Gole
2024-08-21 11:25               ` Rafael J. Wysocki
2015-05-11  3:48           ` [PATCH 0/3] cpuidle: updates related to " Preeti U Murthy
2015-05-11  5:21           ` Preeti U Murthy
2015-05-11 23:13             ` Rafael J. Wysocki
2015-05-11 15:13           ` Sudeep Holla
2015-05-11 23:14             ` Rafael J. Wysocki
2015-05-11 17:40           ` Daniel Lezcano
2015-05-11 23:31             ` Rafael J. Wysocki
2015-05-12  8:41               ` Daniel Lezcano
2015-05-12 13:23                 ` Rafael J. Wysocki
2015-05-12 18:04                   ` Daniel Lezcano
2015-05-13 22:59                   ` Kevin Hilman
2015-05-14  0:16                     ` Rafael J. Wysocki
2015-05-14  0:13                       ` Kevin Hilman
2015-05-14  0:42                         ` Rafael J. Wysocki
2015-05-14  0:31                           ` Kevin Hilman
2015-05-14  3:59                     ` Preeti U Murthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554CAF7A.6060609@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=preeti@linux.vnet.ibm.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rlippert@google.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).