From: Purcareata Bogdan <b43198@freescale.com>
To: Bogdan Purcareata <bogdan.purcareata@freescale.com>,
<linuxppc-dev@lists.ozlabs.org>, <scottwood@freescale.com>,
<segher@kernel.crashing.org>, <benh@kernel.crashing.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/mpic: Remove WHOAMI readback after EOI
Date: Wed, 13 May 2015 15:23:01 +0300 [thread overview]
Message-ID: <55534225.1050305@freescale.com> (raw)
In-Reply-To: <1427193823-14597-1-git-send-email-bogdan.purcareata@freescale.com>
Ping?
On 24.03.2015 12:43, Bogdan Purcareata wrote:
> After previous discussions regarding the subject [1][2], there's no clear
> explanation or reason why the call was needed in the first place. The sensible
> argument is some sort of synchronization between the CPU and the MPIC, which
> hasn't been pointed out precisely and is no longer required (at least on BookE
> platforms).
>
> The benefit of this change is saving a MMIO trap per interrupt when running in a
> KVM guest.
>
> [1] https://patchwork.ozlabs.org/patch/429098/
> [2] https://patchwork.ozlabs.org/patch/433557/
>
> Signed-off-by: Bogdan Purcareata <bogdan.purcareata@freescale.com>
> ---
> arch/powerpc/sysdev/mpic.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
> index bbfbbf2..045e72a9 100644
> --- a/arch/powerpc/sysdev/mpic.c
> +++ b/arch/powerpc/sysdev/mpic.c
> @@ -655,7 +655,6 @@ static inline struct mpic * mpic_from_irq_data(struct irq_data *d)
> static inline void mpic_eoi(struct mpic *mpic)
> {
> mpic_cpu_write(MPIC_INFO(CPU_EOI), 0);
> - (void)mpic_cpu_read(MPIC_INFO(CPU_WHOAMI));
> }
>
> /*
>
next prev parent reply other threads:[~2015-05-13 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 10:43 [PATCH] powerpc/mpic: Remove WHOAMI readback after EOI Bogdan Purcareata
2015-05-13 12:23 ` Purcareata Bogdan [this message]
2015-05-13 16:33 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55534225.1050305@freescale.com \
--to=b43198@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=bogdan.purcareata@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).