linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Anton Blanchard <anton@samba.org>
Cc: mikey@neuling.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, shuahkh@osg.samsung.com
Subject: Re: [PATCH V3 09/13] selftests, powerpc: Add test for DSCR value inheritence across fork
Date: Mon, 18 May 2015 16:18:16 +0530	[thread overview]
Message-ID: <5559C370.3050109@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150518150957.4c228ac4@kryten>

On 05/18/2015 10:39 AM, Anton Blanchard wrote:
> Hi Anshuman,
> 
> Thanks for getting these testcases into the kernel.
> 
>> This patch adds a test to verify that the changed DSCR value inside
>> any process would be inherited to it's child process across the fork
>> system call.
> 
> One issue I do notice (a bug in my original test cases too), is that we
> don't restore the DSCR on exit. I'm not sure we need to go to the
> trouble of saving and restoring it, but we should at least get it back
> to 0 when done.

Will save/restore the system DSCR default before exiting.

> 
> Also a tiny nit, no need for a newline in perror():
> 
> open() failed
> : Permission denied
> 

sure, will remove them.

> With those changes you can add:
> 
> Signed-off-by: Anton Blanchard <anton@samba.org>
> 
> to the patches based on my testcases.

Thanks.

  reply	other threads:[~2015-05-18 10:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-10  8:29 [PATCH V3 00/13] POWER DSCR fixes, improvements, docs and tests Anshuman Khandual
2015-04-10  8:30 ` [PATCH V3 01/13] powerpc: Fix handling of DSCR related facility unavailable exception Anshuman Khandual
2015-04-10  8:30 ` [PATCH V3 02/13] powerpc, process: Remove the unused extern dscr_default Anshuman Khandual
2015-04-10  8:30 ` [PATCH V3 03/13] powerpc, offset: Change PACA_DSCR to PACA_DSCR_DEFAULT Anshuman Khandual
2015-04-10  8:30 ` [PATCH V3 04/13] powerpc, dscr: Added some in-code documentation Anshuman Khandual
2015-04-10  8:30 ` [PATCH V3 05/13] documentation, powerpc: Add documentation for DSCR support Anshuman Khandual
2015-04-10  8:30 ` [PATCH V3 06/13] selftests, powerpc: Add test for system wide DSCR default Anshuman Khandual
2015-04-10  8:30 ` [PATCH V3 07/13] selftests, powerpc: Add test for explicitly changing DSCR value Anshuman Khandual
2015-04-10  8:30 ` [PATCH V3 08/13] selftests, powerpc: Add test for DSCR SPR numbers Anshuman Khandual
2015-04-10  8:30 ` [PATCH V3 09/13] selftests, powerpc: Add test for DSCR value inheritence across fork Anshuman Khandual
2015-05-18  5:09   ` Anton Blanchard
2015-05-18 10:48     ` Anshuman Khandual [this message]
2015-04-10  8:30 ` [PATCH V3 10/13] selftests, powerpc: Add test for DSCR inheritence across fork & exec Anshuman Khandual
2015-04-10  8:30 ` [PATCH V3 11/13] selftests, powerpc: Add test for all DSCR sysfs interfaces Anshuman Khandual
2015-04-10  8:30 ` [PATCH V3 12/13] selftests, powerpc: Add thread based stress test for " Anshuman Khandual
2015-04-10  8:30 ` [PATCH V3 13/13] selftests, powerpc: Add gitignore file for the new DSCR tests Anshuman Khandual
2015-05-12  6:01 ` [PATCH V3 00/13] POWER DSCR fixes, improvements, docs and tests Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5559C370.3050109@linux.vnet.ibm.com \
    --to=khandual@linux.vnet.ibm.com \
    --cc=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).