From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-x22f.google.com (mail-wi0-x22f.google.com [IPv6:2a00:1450:400c:c05::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 98B991A1778 for ; Fri, 29 May 2015 00:00:00 +1000 (AEST) Received: by wicmc15 with SMTP id mc15so124740872wic.1 for ; Thu, 28 May 2015 06:59:57 -0700 (PDT) Message-ID: <55671F5D.6060807@gmail.com> Date: Thu, 28 May 2015 15:59:57 +0200 From: Quentin Lambert MIME-Version: 1.0 To: Takashi Iwai CC: Johannes Berg , Jaroslav Kysela , linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups References: <1432817307-28380-1-git-send-email-lambert.quentin@gmail.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 28/05/2015 15:52, Takashi Iwai wrote: > At Thu, 28 May 2015 14:48:27 +0200, > Quentin Lambert wrote: >> You should use dev_groups instead of the dev_attrs field of struct >> bus_type. This converts the MDIO bus code to use the correct field. >> >> These modifications were made using Coccinelle. >> >> Signed-off-by: Quentin Lambert > What's wrong with dev_attrs? > (Not offending, I'm just curious where the preference for dev_groups > is referred...) This patch is based on commit 4192c74940e23da727eb02b7b4ee779dde2f670, its message indicates that dev_attrs is going away. Quentin