* [PATCH] powerpc/powernv: pnv_init_idle_states() should only run on powernv
@ 2015-06-12 10:00 Michael Ellerman
2015-06-14 16:28 ` Shreyas B Prabhu
0 siblings, 1 reply; 3+ messages in thread
From: Michael Ellerman @ 2015-06-12 10:00 UTC (permalink / raw)
To: linuxppc-dev; +Cc: shreyas
Although this init call checks for device tree properties before doing
anything, it should still only run on powernv machines.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
arch/powerpc/platforms/powernv/idle.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/idle.c b/arch/powerpc/platforms/powernv/idle.c
index bd39a120bd60..e8168cf13812 100644
--- a/arch/powerpc/platforms/powernv/idle.c
+++ b/arch/powerpc/platforms/powernv/idle.c
@@ -289,5 +289,4 @@ out_free:
out:
return 0;
}
-
-subsys_initcall(pnv_init_idle_states);
+machine_subsys_initcall(powernv, pnv_init_idle_states);
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/powernv: pnv_init_idle_states() should only run on powernv
2015-06-12 10:00 [PATCH] powerpc/powernv: pnv_init_idle_states() should only run on powernv Michael Ellerman
@ 2015-06-14 16:28 ` Shreyas B Prabhu
2015-06-15 1:49 ` Michael Ellerman
0 siblings, 1 reply; 3+ messages in thread
From: Shreyas B Prabhu @ 2015-06-14 16:28 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev
On 06/12/2015 03:30 PM, Michael Ellerman wrote:
> Although this init call checks for device tree properties before doing
> anything, it should still only run on powernv machines.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> arch/powerpc/platforms/powernv/idle.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/idle.c b/arch/powerpc/platforms/powernv/idle.c
> index bd39a120bd60..e8168cf13812 100644
> --- a/arch/powerpc/platforms/powernv/idle.c
> +++ b/arch/powerpc/platforms/powernv/idle.c
> @@ -289,5 +289,4 @@ out_free:
> out:
> return 0;
> }
> -
> -subsys_initcall(pnv_init_idle_states);
> +machine_subsys_initcall(powernv, pnv_init_idle_states);
>
<asm/machdep.h> needs to be included, otherwise I get a build error.
With that,
Reviewed-by: Shreyas B Prabhu <shreyas@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/powernv: pnv_init_idle_states() should only run on powernv
2015-06-14 16:28 ` Shreyas B Prabhu
@ 2015-06-15 1:49 ` Michael Ellerman
0 siblings, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2015-06-15 1:49 UTC (permalink / raw)
To: Shreyas B Prabhu; +Cc: linuxppc-dev
On Sun, 2015-06-14 at 21:58 +0530, Shreyas B Prabhu wrote:
>
> On 06/12/2015 03:30 PM, Michael Ellerman wrote:
> > Although this init call checks for device tree properties before doing
> > anything, it should still only run on powernv machines.
> >
> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> > ---
> > arch/powerpc/platforms/powernv/idle.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/arch/powerpc/platforms/powernv/idle.c b/arch/powerpc/platforms/powernv/idle.c
> > index bd39a120bd60..e8168cf13812 100644
> > --- a/arch/powerpc/platforms/powernv/idle.c
> > +++ b/arch/powerpc/platforms/powernv/idle.c
> > @@ -289,5 +289,4 @@ out_free:
> > out:
> > return 0;
> > }
> > -
> > -subsys_initcall(pnv_init_idle_states);
> > +machine_subsys_initcall(powernv, pnv_init_idle_states);
> >
>
> <asm/machdep.h> needs to be included, otherwise I get a build error.
Ah yep, I built the wrong config to test :}
> With that,
> Reviewed-by: Shreyas B Prabhu <shreyas@linux.vnet.ibm.com>
Thanks for testing.
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-15 1:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-12 10:00 [PATCH] powerpc/powernv: pnv_init_idle_states() should only run on powernv Michael Ellerman
2015-06-14 16:28 ` Shreyas B Prabhu
2015-06-15 1:49 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).