From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e39.co.us.ibm.com (e39.co.us.ibm.com [32.97.110.160]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 79B451A03ED for ; Sat, 20 Jun 2015 07:19:29 +1000 (AEST) Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 19 Jun 2015 15:19:26 -0600 Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 6730619D8047 for ; Fri, 19 Jun 2015 15:10:11 -0600 (MDT) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t5JLIXla42401838 for ; Fri, 19 Jun 2015 14:18:33 -0700 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t5JLJAOJ031548 for ; Fri, 19 Jun 2015 15:19:10 -0600 Message-ID: <5584874D.2060402@linux.vnet.ibm.com> Date: Fri, 19 Jun 2015 16:19:09 -0500 From: Brian King MIME-Version: 1.0 To: Michael Ellerman , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org Subject: Re: powerpc/iommu: Support "hybrid" iommu/direct DMA ops for coherent_mask < dma_mask References: <20150518064027.27A97140D18@ozlabs.org> In-Reply-To: <20150518064027.27A97140D18@ozlabs.org> Content-Type: text/plain; charset=windows-1252 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 05/18/2015 01:40 AM, Michael Ellerman wrote: > On Mon, 2015-18-05 at 03:56:51 UTC, Benjamin Herrenschmidt wrote: >> This patch adds the ability to the DMA direct ops to fallback to the IOMMU >> ops for coherent alloc/free if the coherent mask of the device isn't >> suitable for accessing the direct DMA space and the device also happens >> to have an active IOMMU table. > > Can you do the removal of the union, the #ifdef PPC64 and the static inlines as > a precursor patch, that would remove some of the noise in the diff. > > And can you explain the changes to dart, pseries and powernv. > > There's also some whitespace changes in iommu.h that I assume you didn't want? Hi Ben, Do you plan to resubmit with these changes? The patch seems to work fine in my testing. Would be nice to get this merged. Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center