Re: [RFC] Device tree for new desktop platform in arch/powerpc

[Segher Boessenkool <segher@kernel.crashing.org>]

>>>               #address-cells = <1>;
>
> Why #address-cells set to 1 ? In a PIC node, in fact, I would expect it
> to be 0 to avoid any spurrious "reg" matching for interrupts.

The "#address-cells" property should be completely absent,
even; for interrupt matching, that means "treat as 0, no
unit address used in interrupt mapping, just the interrupt
number", and for the "normal" purpose (defining the format
of devices on the bus rooted at / represented by this node)
it means "there is no such bus" -- this is different from
#address-cells = 0.

> Just put the interrupt-parent pointer once in the isa bridge and all 
> isa
> devices below the bridge.

Definitely.

>>>               #address-cells = <1>;
>>>               #size-cells = <0>;                      // No physical
>> address.
>>
>> Comment is arguably incorrect.
>
> Yeah, not sure what that is supposed to be.

#size-cells = 0 means the addressing scheme on this bus is
not directly related to the mechanism (if any) by which
registers on a device on the bus are addressed.


Segher