From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 5776A1A02B5 for ; Tue, 21 Jul 2015 01:08:21 +1000 (AEST) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NRS00AP4KPR8A60@mailout2.w1.samsung.com> for linuxppc-dev@lists.ozlabs.org; Mon, 20 Jul 2015 16:08:15 +0100 (BST) Message-id: <55AD0EDD.70201@samsung.com> Date: Mon, 20 Jul 2015 17:08:13 +0200 From: Krzysztof Opasiak MIME-version: 1.0 To: Robert Baldyga , gregkh@linuxfoundation.org, balbi@ti.com Cc: Peter.Chen@freescale.com, johnyoun@synopsys.com, dahlmann.thomas@arcor.de, nicolas.ferre@atmel.com, cernekee@gmail.com, leoli@freescale.com, daniel@zonque.org, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, michal.simek@xilinx.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-geode@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, andrzej.p@samsung.com, m.szyprowski@samsung.com Subject: Re: [PATCH v3 26/46] usb: gadget: pch_ud: add ep capabilities support References: <1436941953-1327-1-git-send-email-r.baldyga@samsung.com> <1436941953-1327-27-git-send-email-r.baldyga@samsung.com> In-reply-to: <1436941953-1327-27-git-send-email-r.baldyga@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 07/15/2015 08:32 AM, Robert Baldyga wrote: > Convert endpoint configuration to new capabilities model. > > Signed-off-by: Robert Baldyga > --- > drivers/usb/gadget/udc/pch_udc.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc/pch_udc.c > index 613547f..cc8fb3c 100644 > --- a/drivers/usb/gadget/udc/pch_udc.c > +++ b/drivers/usb/gadget/udc/pch_udc.c > @@ -2895,11 +2895,21 @@ static void pch_udc_pcd_reinit(struct pch_udc_dev *dev) > ep->in = ~i & 1; > ep->ep.name = ep_string[i]; > ep->ep.ops = &pch_udc_ep_ops; > - if (ep->in) > + if (ep->in) { > ep->offset_addr = ep->num * UDC_EP_REG_SHIFT; > - else > + ep->ep.caps.dir_in = true; > + } else { > ep->offset_addr = (UDC_EPINT_OUT_SHIFT + ep->num) * > UDC_EP_REG_SHIFT; > + ep->ep.caps.dir_out = true; > + } > + if (i == UDC_EP0IN_IDX || i == UDC_EP0OUT_IDX) { > + ep->ep.caps.type_control = true; In all previous patches you set both dir_in and dir_out to true for ep0 but in this patch you don't do this. Is there some reason for this or it's just a mistake? > + } else { > + ep->ep.caps.type_iso = true; > + ep->ep.caps.type_bulk = true; > + ep->ep.caps.type_int = true; > + } > /* need to set ep->ep.maxpacket and set Default Configuration?*/ > usb_ep_set_maxpacket_limit(&ep->ep, UDC_BULK_MAX_PKT_SIZE); > list_add_tail(&ep->ep.ep_list, &dev->gadget.ep_list); > Best Regards, -- Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics