From: Vlastimil Babka <vbabka@suse.cz>
To: David Rientjes <rientjes@google.com>, Christoph Lameter <cl@linux.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
cbe-oss-dev@lists.ozlabs.org, kvm@vger.kernel.org,
Mel Gorman <mgorman@suse.de>, Greg Thelen <gthelen@google.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>, Arnd Bergmann <arnd@arndb.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Gleb Natapov <gleb@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Cliff Whickman <cpw@sgi.com>, Robin Holt <robinmholt@gmail.com>
Subject: Re: [PATCH] mm: rename and document alloc_pages_exact_node
Date: Fri, 24 Jul 2015 16:52:18 +0200 [thread overview]
Message-ID: <55B25122.5030407@suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.10.1507231322510.31024@chino.kir.corp.google.com>
On 07/23/2015 10:27 PM, David Rientjes wrote:
> On Thu, 23 Jul 2015, Christoph Lameter wrote:
>
>>> The only possible downside would be existing users of
>>> alloc_pages_node() that are calling it with an offline node. Since it's a
>>> VM_BUG_ON() that would catch that, I think it should be changed to a
>>> VM_WARN_ON() and eventually fixed up because it's nonsensical.
>>> VM_BUG_ON() here should be avoided.
>>
>> The offline node thing could be addresses by using numa_mem_id()?
>>
>
> I was concerned about any callers that were passing an offline node, not
> NUMA_NO_NODE, today. One of the alloc-node functions has a VM_BUG_ON()
> for it, the other silently calls node_zonelist() on it.
>
> I suppose the final alloc_pages_node() implementation could be
>
> if (nid == NUMA_NO_NODE || VM_WARN_ON(!node_online(nid)))
> nid = numa_mem_id();
>
> VM_BUG_ON(nid < 0 || nid >= MAX_NUMNODES);
> return __alloc_pages(gfp_mask, order, node_zonelist(nid, gfp_mask));
>
> though.
I've posted v2 based on David's and Christoph's suggestions (thanks) but
to avoid spamming everyone until we agree on the final interface, it's
marked as RFC and excludes the arch people from CC:
http://marc.info/?l=linux-kernel&m=143774920902608&w=2
next prev parent reply other threads:[~2015-07-24 14:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 13:55 [PATCH] mm: rename and document alloc_pages_exact_node Vlastimil Babka
2015-07-21 14:05 ` Christoph Lameter
2015-07-21 14:14 ` Robin Holt
2015-07-21 21:31 ` David Rientjes
2015-07-22 11:32 ` Vlastimil Babka
2015-07-22 21:52 ` David Rientjes
2015-07-23 14:11 ` Christoph Lameter
2015-07-23 20:27 ` David Rientjes
2015-07-24 14:52 ` Vlastimil Babka [this message]
2015-07-22 1:23 ` Michael Ellerman
2015-07-22 11:31 ` Paolo Bonzini
2015-07-22 21:44 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B25122.5030407@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=cbe-oss-dev@lists.ozlabs.org \
--cc=cl@linux.com \
--cc=cpw@sgi.com \
--cc=fenghua.yu@intel.com \
--cc=gleb@kernel.org \
--cc=gthelen@google.com \
--cc=hpa@zytor.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kvm@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=paulus@samba.org \
--cc=pbonzini@redhat.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=robinmholt@gmail.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).