From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-x230.google.com (mail-wi0-x230.google.com [IPv6:2a00:1450:400c:c05::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id F0CFD1A02C2 for ; Wed, 29 Jul 2015 03:42:42 +1000 (AEST) Received: by wicgb10 with SMTP id gb10so167131613wic.1 for ; Tue, 28 Jul 2015 10:42:39 -0700 (PDT) Message-ID: <55B7BEA8.7080107@gmail.com> Date: Tue, 28 Jul 2015 19:40:56 +0200 From: Jacek Anaszewski MIME-Version: 1.0 To: Vasant Hegde , linux-leds@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, j.anaszewski@samsung.com, mpe@ellerman.id.au CC: rpurdie@rpsys.net, cooloney@gmail.com, khandual@linux.vnet.ibm.com, j.anaszewski81@gmail.com, arnd@arndb.de, stewart@linux.vnet.ibm.com, benh@kernel.crashing.org Subject: Re: [PATCH v8 3/3] leds/powernv: Add driver for PowerNV platform References: <1437801670-23705-1-git-send-email-hegdevasant@linux.vnet.ibm.com> <1437801670-23705-4-git-send-email-hegdevasant@linux.vnet.ibm.com> <55B5540B.1000301@gmail.com> <55B5A853.3080909@linux.vnet.ibm.com> <55B5FEDD.2000506@gmail.com> <55B7865E.8000402@linux.vnet.ibm.com> In-Reply-To: <55B7865E.8000402@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Vasant, On 28.07.2015 15:40, Vasant Hegde wrote: > On 07/27/2015 03:20 PM, Jacek Anaszewski wrote: >> Hi Vasant, >> >> On 27.07.2015 05:41, Vasant Hegde wrote: >>> On 07/27/2015 03:11 AM, Jacek Anaszewski wrote: >>>> Hi Vasant, >>>> >>> >>> Hi Jacek, >>> >>>> Two trivial details left. Please find them below. >>> >>> Thanks for the review/Ack. I'll fix below issues and resend patchset. >>> >>> I will ask Benh/Michael to take this patchset. But this patchset is depending >>> on your core changes. Can you confirm that you are pushing that patchset in next >>> merge window? > > Jacek, > >> >> Without my core changes your driver won't work with led triggers, but >> AFAIR this use case is not relevant for your LEDs? Eventually, we could >> produce a patch set adding support for LED triggers if it will be clear >> that LED core changes will not be merged in the upcoming merge window. > > IIUC current LED code doesn't allow me to sleep (without driver specific > workqueue). And powernv_led_set() call will sleep. Hence I think it won't work. > > I did a quick test without your patch. It doesn't seems to be working. Strange, it should work when led_set_brightness is called from non atomic context, e.g. from sysfs interface. Could you share your test scenario and describe the symptoms? > Alternatively we can revert the changes (add driver specific workqueue now) and > later when your changes goes to upstream, I can fix my code. You can add this as an incremental patch which would be easy to revert when LED core changes are merged. -- Best Regards, Jacek Anaszewski