[PATCH] powerpc/prom: Use DRCONF flags while processing detected LMBs

[PATCH] powerpc/prom: Use DRCONF flags while processing detected LMBs

[Anshuman Khandual]

This patch just replaces hard coded values with existing
DRCONF flags while procesing detected LMBs from the device
tree. This does not change any functionality.

Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
---
 arch/powerpc/kernel/prom.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c
index 8b888b1..70a8cab 100644
--- a/arch/powerpc/kernel/prom.c
+++ b/arch/powerpc/kernel/prom.c
@@ -476,9 +476,10 @@ static int __init early_init_dt_scan_drconf_memory(unsigned long node)
 		flags = of_read_number(&dm[3], 1);
 		/* skip DRC index, pad, assoc. list index, flags */
 		dm += 4;
-		/* skip this block if the reserved bit is set in flags (0x80)
-		   or if the block is not assigned to this partition (0x8) */
-		if ((flags & 0x80) || !(flags & 0x8))
+		/* skip this block if the reserved bit is set in flags
+		   or if the block is not assigned to this partition */
+		if ((flags & DRCONF_MEM_RESERVED) ||
+				!(flags & DRCONF_MEM_ASSIGNED))
 			continue;
 		size = memblock_size;
 		rngs = 1;
-- 
2.1.0

Re: [PATCH] powerpc/prom: Use DRCONF flags while processing detected LMBs

[Madhavan Srinivasan]

On Thursday 06 August 2015 06:35 PM, Anshuman Khandual wrote:
> This patch just replaces hard coded values with existing

  Please drop "This patch just" and start with "Replace hard ..."

  https://www.kernel.org/doc/Documentation/SubmittingPatches 

  Maddy

> DRCONF flags while procesing detected LMBs from the device
> tree. This does not change any functionality.
>
> Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
> ---
>  arch/powerpc/kernel/prom.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c
> index 8b888b1..70a8cab 100644
> --- a/arch/powerpc/kernel/prom.c
> +++ b/arch/powerpc/kernel/prom.c
> @@ -476,9 +476,10 @@ static int __init early_init_dt_scan_drconf_memory(unsigned long node)
>  		flags = of_read_number(&dm[3], 1);
>  		/* skip DRC index, pad, assoc. list index, flags */
>  		dm += 4;
> -		/* skip this block if the reserved bit is set in flags (0x80)
> -		   or if the block is not assigned to this partition (0x8) */
> -		if ((flags & 0x80) || !(flags & 0x8))
> +		/* skip this block if the reserved bit is set in flags
> +		   or if the block is not assigned to this partition */
> +		if ((flags & DRCONF_MEM_RESERVED) ||
> +				!(flags & DRCONF_MEM_ASSIGNED))
>  			continue;
>  		size = memblock_size;
>  		rngs = 1;

Re: [PATCH] powerpc/prom: Use DRCONF flags while processing detected LMBs

[Michael Ellerman]

On Fri, 2015-08-07 at 07:49 +0530, Madhavan Srinivasan wrote:
> 
> On Thursday 06 August 2015 06:35 PM, Anshuman Khandual wrote:
> > This patch just replaces hard coded values with existing
> 
>   Please drop "This patch just" and start with "Replace hard ..."
> 
>   https://www.kernel.org/doc/Documentation/SubmittingPatches 

Yeah I rewrote it as:

    Replace hard coded values with existing DRCONF flags while procesing
    detected LMBs from the device tree. Does not change any functionality.


cheers

Re: [PATCH] powerpc/prom: Use DRCONF flags while processing detected LMBs

[Anshuman Khandual]

On 08/11/2015 03:18 AM, Michael Ellerman wrote:
> On Fri, 2015-08-07 at 07:49 +0530, Madhavan Srinivasan wrote:
>> > 
>> > On Thursday 06 August 2015 06:35 PM, Anshuman Khandual wrote:
>>> > > This patch just replaces hard coded values with existing
>> > 
>> >   Please drop "This patch just" and start with "Replace hard ..."
>> > 
>> >   https://www.kernel.org/doc/Documentation/SubmittingPatches 
> Yeah I rewrote it as:
> 
>     Replace hard coded values with existing DRCONF flags while procesing
>     detected LMBs from the device tree. Does not change any functionality.

Thanks Michael.

Re: powerpc/prom: Use DRCONF flags while processing detected LMBs

[Michael Ellerman]

On Thu, 2015-06-08 at 13:05:07 UTC, Anshuman Khandual wrote:
> This patch just replaces hard coded values with existing
> DRCONF flags while procesing detected LMBs from the device
> tree. This does not change any functionality.
> 
> Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/9afac933433ca71e0f78

cheers