From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Cc: mikey@neuling.org
Subject: Re: [4/8] powerpc/slb: Add some helper functions to improve modularization
Date: Wed, 12 Aug 2015 12:06:39 +0530 [thread overview]
Message-ID: <55CAE977.7020803@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150812041117.CFFC91401CD@ozlabs.org>
On 08/12/2015 09:41 AM, Michael Ellerman wrote:
> On Wed, 2015-29-07 at 07:10:01 UTC, Anshuman Khandual wrote:
>> > This patch adds the following six helper functions to help improve
>> > modularization and readability of the code.
>> >
>> > (1) slb_invalidate_all: Invalidates the entire SLB
>> > (2) slb_invalidate: Invalidates SLB entries present in PACA
>> > (3) mmu_linear_vsid_flags: VSID flags for kernel linear mapping
>> > (4) mmu_virtual_vsid_flags: VSID flags for kernel virtual mapping
>> > (5) mmu_vmemmap_vsid_flags: VSID flags for kernel vmem mapping
>> > (6) mmu_io_vsid_flags: VSID flags for kernel I/O mapping
> That's too many changes for one patch, it's certainly not a single logical change.
>
> I'm happy with all the flag ones being done in a single patch, but please do
> the other two in separate patches.
Sure, will split this into three separate patches, also update the
in-code documentation as suggested on the [5/8] patch and then will
send out a new series.
next prev parent reply other threads:[~2015-08-12 6:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 7:09 [PATCH 1/8] powerpc/slb: Remove a duplicate extern variable Anshuman Khandual
2015-07-29 7:09 ` [PATCH 2/8] powerpc/slb: Rename all the 'slot' occurrences to 'entry' Anshuman Khandual
2015-08-13 1:44 ` [2/8] " Michael Ellerman
2015-07-29 7:10 ` [PATCH 3/8] powerpc/slb: Define macros for the bolted slots Anshuman Khandual
2015-07-29 7:10 ` [PATCH 4/8] powerpc/slb: Add some helper functions to improve modularization Anshuman Khandual
2015-08-12 4:11 ` [4/8] " Michael Ellerman
2015-08-12 6:36 ` Anshuman Khandual [this message]
2015-07-29 7:10 ` [PATCH 5/8] powerpc/slb: Add documentation to runtime patching of SLB encoding Anshuman Khandual
2015-08-12 5:12 ` [5/8] " Michael Ellerman
2015-08-13 1:44 ` Michael Ellerman
2015-07-29 7:10 ` [PATCH 6/8] powerpc/prom: Simplify the logic while fetching SLB size Anshuman Khandual
2015-08-13 1:44 ` [6/8] " Michael Ellerman
2015-07-29 7:10 ` [PATCH 7/8] powerpc/xmon: Drop the 'valid' variable completely in 'dump_segments' Anshuman Khandual
2015-08-13 1:44 ` [7/8] " Michael Ellerman
2015-07-29 7:10 ` [PATCH 8/8] powerpc/xmon: Add some more elements to the existing PACA dump list Anshuman Khandual
2015-08-12 6:05 ` Michael Ellerman
2015-08-12 6:27 ` Anshuman Khandual
2015-08-13 1:44 ` [1/8] powerpc/slb: Remove a duplicate extern variable Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CAE977.7020803@linux.vnet.ibm.com \
--to=khandual@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).