From: David Vrabel <david.vrabel@citrix.com>
To: Julien Grall <julien.grall@citrix.com>, <xen-devel@lists.xenproject.org>
Cc: <ian.campbell@citrix.com>, <stefano.stabellini@eu.citrix.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
<linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
David Vrabel <david.vrabel@citrix.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
Jiri Slaby <jslaby@suse.cz>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [Xen-devel] [PATCH v3 11/20] tty/hvc: xen: Use xen page definition
Date: Thu, 20 Aug 2015 10:55:58 +0100 [thread overview]
Message-ID: <55D5A42E.7070800@citrix.com> (raw)
In-Reply-To: <1438966019-19322-12-git-send-email-julien.grall@citrix.com>
On 07/08/15 17:46, Julien Grall wrote:
> The console ring is always based on the page granularity of Xen.
[...]
> --- a/drivers/tty/hvc/hvc_xen.c
> +++ b/drivers/tty/hvc/hvc_xen.c
> @@ -230,7 +230,7 @@ static int xen_hvm_console_init(void)
> if (r < 0 || v == 0)
> goto err;
> gfn = v;
> - info->intf = xen_remap(gfn << PAGE_SHIFT, PAGE_SIZE);
> + info->intf = xen_remap(gfn << XEN_PAGE_SHIFT, PAGE_SIZE);
You need XEN_PAGE_SIZE here I think...
> if (info->intf == NULL)
> goto err;
> info->vtermno = HVC_COOKIE;
> @@ -472,7 +472,7 @@ static int xencons_resume(struct xenbus_device *dev)
> struct xencons_info *info = dev_get_drvdata(&dev->dev);
>
> xencons_disconnect_backend(info);
> - memset(info->intf, 0, PAGE_SIZE);
> + memset(info->intf, 0, XEN_PAGE_SIZE);
...particularly since you use it here.
David
next prev parent reply other threads:[~2015-08-20 9:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1438966019-19322-1-git-send-email-julien.grall@citrix.com>
2015-08-07 16:46 ` [PATCH v3 11/20] tty/hvc: xen: Use xen page definition Julien Grall
2015-08-20 9:55 ` David Vrabel [this message]
2015-08-28 15:03 ` [Xen-devel] " Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D5A42E.7070800@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=ian.campbell@citrix.com \
--cc=jslaby@suse.cz \
--cc=julien.grall@citrix.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).