linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc/configs: Enable LEDS support
@ 2015-08-25  7:54 Vasant Hegde
  2015-08-26  0:26 ` Stewart Smith
  0 siblings, 1 reply; 3+ messages in thread
From: Vasant Hegde @ 2015-08-25  7:54 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: linux-leds, j.anaszewski, mpe, Vasant Hegde

Commit 84ad6e5c added LEDS support for PowerNV platform. Lets
update ppc64_defconfig to pick LEDS driver.

Presently PowerNV LEDS driver is specific to FSP based PowerNV
platform. Hence added it as 'm'. So that we will be loaded only
if we have required device tree support.

Also note that powernv LEDS driver needs NEW_LEDS and LEDS_CLASS
as well. Hence added them to config file.

Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
---
Michael,
  This is PowerNV specific config. Hence I've not updated pseries_defconfig.
  Let me know if you want me to update pseries_defconfig config as well.

Vasant

 arch/powerpc/configs/ppc64_defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/powerpc/configs/ppc64_defconfig b/arch/powerpc/configs/ppc64_defconfig
index a97efc2..6bc0ee4 100644
--- a/arch/powerpc/configs/ppc64_defconfig
+++ b/arch/powerpc/configs/ppc64_defconfig
@@ -355,3 +355,6 @@ CONFIG_CRYPTO_DEV_NX_ENCRYPT=m
 CONFIG_VIRTUALIZATION=y
 CONFIG_KVM_BOOK3S_64=m
 CONFIG_KVM_BOOK3S_64_HV=m
+CONFIG_NEW_LEDS=y
+CONFIG_LEDS_CLASS=m
+CONFIG_LEDS_POWERNV=m
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] powerpc/configs: Enable LEDS support
  2015-08-25  7:54 [PATCH] powerpc/configs: Enable LEDS support Vasant Hegde
@ 2015-08-26  0:26 ` Stewart Smith
  2015-08-26  4:16   ` Vasant Hegde
  0 siblings, 1 reply; 3+ messages in thread
From: Stewart Smith @ 2015-08-26  0:26 UTC (permalink / raw)
  To: Vasant Hegde, linuxppc-dev; +Cc: Vasant Hegde, j.anaszewski, linux-leds

Vasant Hegde <hegdevasant@linux.vnet.ibm.com> writes:
> Presently PowerNV LEDS driver is specific to FSP based PowerNV
> platform. Hence added it as 'm'. So that we will be loaded only
> if we have required device tree support.

Currently the *firmware* support is FSP specific.

The driver should magically work on any OPAL machine that hooks up the
OPAL calls and DT. Right?

The A in OPAL is for Abstraction, not P for Passthrough-to-fsp.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] powerpc/configs: Enable LEDS support
  2015-08-26  0:26 ` Stewart Smith
@ 2015-08-26  4:16   ` Vasant Hegde
  0 siblings, 0 replies; 3+ messages in thread
From: Vasant Hegde @ 2015-08-26  4:16 UTC (permalink / raw)
  To: Stewart Smith, linuxppc-dev; +Cc: j.anaszewski, linux-leds

On 08/26/2015 05:56 AM, Stewart Smith wrote:
> Vasant Hegde <hegdevasant@linux.vnet.ibm.com> writes:
>> Presently PowerNV LEDS driver is specific to FSP based PowerNV
>> platform. Hence added it as 'm'. So that we will be loaded only
>> if we have required device tree support.

Stewart,

> 
> Currently the *firmware* support is FSP specific.
> 
> The driver should magically work on any OPAL machine that hooks up the
> OPAL calls and DT. Right?

Yep. It will just work if we have appropriate device tree . I'll update the
description and resend patch.


> 
> The A in OPAL is for Abstraction, not P for Passthrough-to-fsp.
> 

:-)

-Vasant

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-08-26  4:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-25  7:54 [PATCH] powerpc/configs: Enable LEDS support Vasant Hegde
2015-08-26  0:26 ` Stewart Smith
2015-08-26  4:16   ` Vasant Hegde

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).