* [PATCH FIX] powerpc/pseries: Release DRC when configure_connector fails
@ 2015-09-04 10:04 Bharata B Rao
2015-09-04 14:42 ` Nathan Fontenot
2015-09-07 9:22 ` [FIX] " Michael Ellerman
0 siblings, 2 replies; 4+ messages in thread
From: Bharata B Rao @ 2015-09-04 10:04 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Bharata B Rao, Nathan Fontenot
From: Bharata B Rao <bharata@linux.vnet.ibm.com>
dlpar_cpu_probe() should release the acquired DRC if configure_connector
call fails.
Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
Cc: Nathan Fontenot <nfont@linux.vnet.ibm.com>
---
arch/powerpc/platforms/pseries/dlpar.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c
index 47d9cebe..db17827 100644
--- a/arch/powerpc/platforms/pseries/dlpar.c
+++ b/arch/powerpc/platforms/pseries/dlpar.c
@@ -422,8 +422,10 @@ static ssize_t dlpar_cpu_probe(const char *buf, size_t count)
dn = dlpar_configure_connector(cpu_to_be32(drc_index), parent);
of_node_put(parent);
- if (!dn)
+ if (!dn) {
+ dlpar_release_drc(drc_index);
return -EINVAL;
+ }
rc = dlpar_attach_node(dn);
if (rc) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH FIX] powerpc/pseries: Release DRC when configure_connector fails
2015-09-04 10:04 [PATCH FIX] powerpc/pseries: Release DRC when configure_connector fails Bharata B Rao
@ 2015-09-04 14:42 ` Nathan Fontenot
2015-09-07 9:22 ` [FIX] " Michael Ellerman
1 sibling, 0 replies; 4+ messages in thread
From: Nathan Fontenot @ 2015-09-04 14:42 UTC (permalink / raw)
To: Bharata B Rao, linuxppc-dev; +Cc: Bharata B Rao
On 09/04/2015 05:04 AM, Bharata B Rao wrote:
> From: Bharata B Rao <bharata@linux.vnet.ibm.com>
>
> dlpar_cpu_probe() should release the acquired DRC if configure_connector
> call fails.
>
> Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> Cc: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Reviewed-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
> ---
> arch/powerpc/platforms/pseries/dlpar.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c
> index 47d9cebe..db17827 100644
> --- a/arch/powerpc/platforms/pseries/dlpar.c
> +++ b/arch/powerpc/platforms/pseries/dlpar.c
> @@ -422,8 +422,10 @@ static ssize_t dlpar_cpu_probe(const char *buf, size_t count)
>
> dn = dlpar_configure_connector(cpu_to_be32(drc_index), parent);
> of_node_put(parent);
> - if (!dn)
> + if (!dn) {
> + dlpar_release_drc(drc_index);
> return -EINVAL;
> + }
>
> rc = dlpar_attach_node(dn);
> if (rc) {
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FIX] powerpc/pseries: Release DRC when configure_connector fails
2015-09-04 10:04 [PATCH FIX] powerpc/pseries: Release DRC when configure_connector fails Bharata B Rao
2015-09-04 14:42 ` Nathan Fontenot
@ 2015-09-07 9:22 ` Michael Ellerman
2015-09-07 10:24 ` Bharata B Rao
1 sibling, 1 reply; 4+ messages in thread
From: Michael Ellerman @ 2015-09-07 9:22 UTC (permalink / raw)
To: Bharata B Rao, linuxppc-dev; +Cc: Nathan Fontenot, Bharata B Rao
On Fri, 2015-04-09 at 10:04:12 UTC, Bharata B Rao wrote:
> From: Bharata B Rao <bharata@linux.vnet.ibm.com>
>
> dlpar_cpu_probe() should release the acquired DRC if configure_connector
> call fails.
>
> Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> Cc: Nathan Fontenot <nfont@linux.vnet.ibm.com>
> Reviewed-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Which commit caused this to be a bug? Or has it always been there?
What is the symptom, is it catastrophic, or just cosmetic?
Should the fix go to stable?
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FIX] powerpc/pseries: Release DRC when configure_connector fails
2015-09-07 9:22 ` [FIX] " Michael Ellerman
@ 2015-09-07 10:24 ` Bharata B Rao
0 siblings, 0 replies; 4+ messages in thread
From: Bharata B Rao @ 2015-09-07 10:24 UTC (permalink / raw)
To: Michael Ellerman; +Cc: Bharata B Rao, linuxppc-dev, Nathan Fontenot
On Mon, Sep 07, 2015 at 07:22:04PM +1000, Michael Ellerman wrote:
> On Fri, 2015-04-09 at 10:04:12 UTC, Bharata B Rao wrote:
> > From: Bharata B Rao <bharata@linux.vnet.ibm.com>
> >
> > dlpar_cpu_probe() should release the acquired DRC if configure_connector
> > call fails.
> >
> > Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> > Cc: Nathan Fontenot <nfont@linux.vnet.ibm.com>
> > Reviewed-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
>
> Which commit caused this to be a bug? Or has it always been there?
>
> What is the symptom, is it catastrophic, or just cosmetic?
>
> Should the fix go to stable?
Posted v1 with the above questions answered appropriately.
Regards,
Bharata.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-07 10:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-04 10:04 [PATCH FIX] powerpc/pseries: Release DRC when configure_connector fails Bharata B Rao
2015-09-04 14:42 ` Nathan Fontenot
2015-09-07 9:22 ` [FIX] " Michael Ellerman
2015-09-07 10:24 ` Bharata B Rao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).