From: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] cxl: abort cxl_pci_enable_device_hook() if PCI channel is offline
Date: Mon, 07 Sep 2015 10:22:31 +1000 [thread overview]
Message-ID: <55ECD8C7.8040600@au1.ibm.com> (raw)
In-Reply-To: <1441583849-sup-2488@delenn.ozlabs.ibm.com>
On 07/09/15 09:58, Ian Munsie wrote:
> Excerpts from andrew.donnellan's message of 2015-09-04 16:20:24 +1000:
>> + if (!cxl_adapter_link_ok(afu->adapter))
>> + dev_warn(&dev->dev, "%s: Device link is down, refusing to enable AFU\n", __func__);
>> + return false;
>
> Based on the indentation it looks like you meant to add some curly
> brackets here.
Indeed I did, and I'd even thought I'd tested it... this is why I
shouldn't be allowed to submit patches at 4pm on Fridays...
Will submit V2.
(FWIW, I'm a firm believer in braces around single statements in
conditionals to avoid mistakes like this, but CodingStyle disagrees...)
Andrew
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnellan@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work) IBM Australia Limited
next prev parent reply other threads:[~2015-09-07 0:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 6:20 [PATCH] cxl: abort cxl_pci_enable_device_hook() if PCI channel is offline Andrew Donnellan
2015-09-06 23:58 ` Ian Munsie
2015-09-07 0:22 ` Andrew Donnellan [this message]
2015-09-07 6:33 ` Ian Munsie
2015-09-07 8:43 ` Michael Ellerman
2015-09-07 0:47 ` Andrew Donnellan
2015-09-07 1:01 ` Ian Munsie
2015-09-07 0:52 ` [PATCH v2] " Andrew Donnellan
2015-09-07 1:09 ` Ian Munsie
2015-09-07 2:53 ` Michael Ellerman
2015-09-07 4:00 ` Andrew Donnellan
2015-09-08 12:05 ` [v2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ECD8C7.8040600@au1.ibm.com \
--to=andrew.donnellan@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).