From: "Bryant G. Ly" <bryantly@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
benh@kernel.crashing.org, paulus@samba.org
Cc: martin.petersen@oracle.com, linuxppc-dev@lists.ozlabs.org,
"Bryant G. Ly" <bgly@us.ibm.com>
Subject: Re: [PATCH] powerpc/kernel: Change retrieval of pci_dn
Date: Tue, 29 Aug 2017 08:18:34 -0500 [thread overview]
Message-ID: <560467db-963b-46f1-bb7b-63892fb5496d@linux.vnet.ibm.com> (raw)
In-Reply-To: <87tw0q289e.fsf@concordia.ellerman.id.au>
On 8/29/17 1:33 AM, Michael Ellerman wrote:
> "Bryant G. Ly" <bryantly@linux.vnet.ibm.com> writes:
>
>> For a PCI device it's pci_dn can be retrieved from
>> pdev->dev.archdata.firmware_data, PCI_DN(devnode), or parent's list.
>> Thus, we should just use the generic function pci_get_pdn_by_devfn
>> to get the pci_dn.
>>
>> Signed-off-by: Bryant G. Ly <bgly@us.ibm.com>
> Minor issue, it's preferable if the email in your Signed-off-by matches
> the email you send patches from.
>
> cheers
>
Hi Michael,
Thanks for the review. I apologize for the email's not matching, I switch between the two frequently
throughout the day for internal gerrit commits and Linux patches. I have addressed all your comments
in the new patch that I had just put up. Also, I have tested it with mellanox cx4 cards on P8 systems.
I'd also like to let you know that I am working on patches to enable SRIOV on power and would like
your feedback on design, which I will send in a private email.
-Bryant
next prev parent reply other threads:[~2017-08-29 13:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 16:05 [PATCH] powerpc/kernel: Change retrieval of pci_dn Bryant G. Ly
2017-08-29 6:20 ` Sam Bobroff
2017-08-29 13:19 ` Bryant G. Ly
2017-08-29 6:31 ` Michael Ellerman
2017-08-29 6:33 ` Michael Ellerman
2017-08-29 13:18 ` Bryant G. Ly [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-08-29 13:11 Bryant G. Ly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560467db-963b-46f1-bb7b-63892fb5496d@linux.vnet.ibm.com \
--to=bryantly@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bgly@us.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.petersen@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).