From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id CC0F91A0A4A for ; Fri, 2 Oct 2015 23:16:08 +1000 (AEST) Subject: Re: [PATCH v5 10/34] cxlflash: Make functions static To: "Matthew R. Ochs" , linux-scsi@vger.kernel.org, James Bottomley , "Nicholas A. Bellinger" , Brian King , Ian Munsie , Daniel Axtens , Andrew Donnellan , David Laight References: <1443714773-9176-1-git-send-email-mrochs@linux.vnet.ibm.com> <1443714936-15625-1-git-send-email-mrochs@linux.vnet.ibm.com> Cc: Michael Neuling , linuxppc-dev@lists.ozlabs.org, "Manoj N. Kumar" From: Tomas Henzl Message-ID: <560E8393.6060904@redhat.com> Date: Fri, 2 Oct 2015 15:16:03 +0200 MIME-Version: 1.0 In-Reply-To: <1443714936-15625-1-git-send-email-mrochs@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 1.10.2015 17:55, Matthew R. Ochs wrote: > Found during code inspection, that the following functions are not > being used outside of the file where they are defined. Make them static. > > int cxlflash_send_cmd(struct afu *, struct afu_cmd *); > void cxlflash_wait_resp(struct afu *, struct afu_cmd *); > int cxlflash_afu_reset(struct cxlflash_cfg *); > struct afu_cmd *cxlflash_cmd_checkout(struct afu *); > void cxlflash_cmd_checkin(struct afu_cmd *); > void init_pcr(struct cxlflash_cfg *); > int init_global(struct cxlflash_cfg *); > > Signed-off-by: Matthew R. Ochs > Signed-off-by: Manoj N. Kumar > Reviewed-by: Brian King Reviewed-by: Tomas Henzl Tomas