From: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org,
gwshan@linux.vnet.ibm.com, benh@kernel.crashing.org,
paulus@samba.org, Fam Zheng <famz@redhat.com>,
Yinghai Lu <yinghai@kernel.org>,
Yijing Wang <wangyijing@huawei.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2 2/2] powerpc/PCI: Disable MSI/MSI-X interrupts at PCI probe time in OF case
Date: Thu, 8 Oct 2015 13:05:35 -0300 [thread overview]
Message-ID: <5616944F.6090608@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150915161821.GB25767@google.com>
On 09/15/2015 01:18 PM, Bjorn Helgaas wrote:
> We could also argue that when CONFIG_PCI_MSI=n, dev->msi[x]_cap should not
> even exist, so we could catch that a build-time instead of run-time. My
> personal opinion is that it's not a big deal, and the existing code that
> includes dev->msi[x]_cap and initializes it even when CONFIG_PCI_MSI=n
> allows some useful code sharing.
Nice Bjorn, so let's follow your idea regarding moving the code of MSI
capabilities initialization to allow some code sharing. It's good option
specially since it avoids the same problem (MSI capabilities not
found)to occur in SPARC arch too.
Sorry for my delay in response, soon I'll send the patch to the list.
Cheers,
Guilherme
next prev parent reply other threads:[~2015-10-08 16:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 21:13 [PATCH 0/2] Disable MSI/MSI-X interrupts manually at PCI probe time in PowerPC architecture Guilherme G. Piccoli
2015-08-18 21:13 ` [PATCH 1/2] PCI: Make pci_msi_setup_pci_dev() non-static for use by arch code Guilherme G. Piccoli
2015-08-19 0:44 ` Michael Ellerman
[not found] ` <1439932077-11427-2-git-send-email-gpiccoli@linux.vnet.ibm.com>
2015-08-19 18:45 ` [PATCH v2 " Guilherme G. Piccoli
2015-08-20 1:02 ` Michael Ellerman
2015-08-20 19:10 ` Guilherme G. Piccoli
2015-08-24 7:37 ` Michael Ellerman
2015-08-24 12:18 ` Guilherme G. Piccoli
2015-08-18 21:13 ` [PATCH 2/2] powerpc/PCI: Disable MSI/MSI-X interrupts at PCI probe time in OF case Guilherme G. Piccoli
[not found] ` <1439932077-11427-3-git-send-email-gpiccoli@linux.vnet.ibm.com>
2015-08-19 18:54 ` [PATCH v2 " Guilherme G. Piccoli
2015-09-03 17:56 ` Bjorn Helgaas
2015-09-04 23:17 ` Guilherme G. Piccoli
2015-09-04 22:59 ` jeclark2006
2015-09-06 14:44 ` Michael S. Tsirkin
2015-09-07 3:17 ` Michael Ellerman
2015-09-07 23:04 ` Guilherme G. Piccoli
2015-09-15 16:18 ` Bjorn Helgaas
2015-10-08 16:05 ` Guilherme G. Piccoli [this message]
2015-09-07 3:10 ` Michael Ellerman
2015-09-07 23:07 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5616944F.6090608@linux.vnet.ibm.com \
--to=gpiccoli@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=famz@redhat.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=paulus@samba.org \
--cc=wangyijing@huawei.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).