From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 927811A178F for ; Sat, 24 Oct 2015 00:41:08 +1100 (AEDT) Subject: Re: [PATCH v6 19/37] cxlflash: Correct usage of scsi_host_put() To: "Matthew R. Ochs" , linux-scsi@vger.kernel.org, James Bottomley , "Nicholas A. Bellinger" , Brian King , Ian Munsie , Daniel Axtens , Andrew Donnellan , David Laight References: <1445458134-63197-1-git-send-email-mrochs@linux.vnet.ibm.com> <1445458449-22858-1-git-send-email-mrochs@linux.vnet.ibm.com> Cc: Michael Neuling , "Manoj N. Kumar" , linuxppc-dev@lists.ozlabs.org From: Tomas Henzl Message-ID: <562A38EF.7020104@redhat.com> Date: Fri, 23 Oct 2015 15:41:03 +0200 MIME-Version: 1.0 In-Reply-To: <1445458449-22858-1-git-send-email-mrochs@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 21.10.2015 22:14, Matthew R. Ochs wrote: > Currently, scsi_host_put() is being called prematurely in the > remove path and is missing entirely in an error cleanup path. > The former can lead to memory being freed too early with > subsequent access potentially corrupting data whilst the former > would result in a memory leak. > > Move the usage on remove to be the last cleanup action taken > and introduce a call to scsi_host_put() in the one initialization > error path that does not use remove to cleanup. > > Signed-off-by: Matthew R. Ochs > Signed-off-by: Manoj N. Kumar > Reviewed-by: Brian King Reviewed-by: Tomas Henzl Tomas