From: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
To: Frederic Barrat <frederic.barrat@fr.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Cc: imunsie@au1.ibm.com
Subject: Re: [PATCH] cxl: Fix reference count on struct pid when attaching
Date: Fri, 30 Oct 2015 11:31:02 +1100 [thread overview]
Message-ID: <5632BA46.8010309@au1.ibm.com> (raw)
In-Reply-To: <1446122343-26068-1-git-send-email-frederic.barrat@fr.ibm.com>
On 29/10/15 23:39, Frederic Barrat wrote:
> When the cxl driver creates a context, it stores the pid of the
> calling task, incrementing the reference count on the struct
> pid. Current code mistakenly increments the reference count twice,
> once through get_task_pid(), once through get_pid(). The reference
> count is only decremented once on detach, thus the struct pid of the
> task attaching is never freed. The fix is to simply remove the call to
> get_pid().
>
> Signed-off-by: Frederic Barrat <frederic.barrat@fr.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnellan@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work) IBM Australia Limited
next prev parent reply other threads:[~2015-10-30 0:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 12:39 [PATCH] cxl: Fix reference count on struct pid when attaching Frederic Barrat
2015-10-30 0:31 ` Andrew Donnellan [this message]
2015-10-30 2:56 ` Ian Munsie
2015-11-02 0:53 ` Michael Ellerman
2015-11-02 23:48 ` Ian Munsie
2015-11-03 1:00 ` Michael Ellerman
2015-11-03 8:17 ` Frederic Barrat
2015-11-03 9:11 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5632BA46.8010309@au1.ibm.com \
--to=andrew.donnellan@au1.ibm.com \
--cc=frederic.barrat@fr.ibm.com \
--cc=imunsie@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).