* Re: powerpc/fsl-pci: Unify pci/pcie initialization code
@ 2015-11-05 18:48 Daniel Walker
2015-11-05 23:12 ` Scott Wood
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Walker @ 2015-11-05 18:48 UTC (permalink / raw)
To: Jia Hongtao
Cc: Scott Wood, Kumar Gala, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, linuxppc-dev, David Beazley (dbeazley),
xe-kernel@external.cisco.com
Hi,
905e75c46dba5f3061049277e4eb7110beedba43:arch/powerpc/platforms/85xx/mpc85xx_ads.c
This commit seems to cause problems with PCI devices doing DMA, just
with mpc85xx ads. If you do the "fsl_add_bridge()" after you setup the
ppc_md.pci_exclude_device to mpc85xx_exclude_device, then the
early_read_config_word() calls in
arch/powerpc/sysdev/fsl_pci.c:setup_pci_cmd() are like no-ops.
This issue was found by David Beazley (on the CC), he can respond to
more detailed questions on it. The fix he came up with was to remove the
"pci_exclude_device".
Daniel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: powerpc/fsl-pci: Unify pci/pcie initialization code
2015-11-05 18:48 powerpc/fsl-pci: Unify pci/pcie initialization code Daniel Walker
@ 2015-11-05 23:12 ` Scott Wood
2015-11-05 23:16 ` Daniel Walker
0 siblings, 1 reply; 4+ messages in thread
From: Scott Wood @ 2015-11-05 23:12 UTC (permalink / raw)
To: Daniel Walker
Cc: Jia Hongtao, Kumar Gala, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, linuxppc-dev, David Beazley (dbeazley),
xe-kernel@external.cisco.com
On Thu, 2015-11-05 at 10:48 -0800, Daniel Walker wrote:
> Hi,
>
> 905e75c46dba5f3061049277e4eb7110beedba43:arch/powerpc/platforms/85xx/mpc85xx_ads.c
>
>
> This commit seems to cause problems with PCI devices doing DMA, just
> with mpc85xx ads. If you do the "fsl_add_bridge()" after you setup the
> ppc_md.pci_exclude_device to mpc85xx_exclude_device, then the
> early_read_config_word() calls in
> arch/powerpc/sysdev/fsl_pci.c:setup_pci_cmd() are like no-ops.
>
> This issue was found by David Beazley (on the CC), he can respond to
> more detailed questions on it. The fix he came up with was to remove the
> "pci_exclude_device".
>
> Daniel
OK, please send a patch.
-Scott
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: powerpc/fsl-pci: Unify pci/pcie initialization code
2015-11-05 23:12 ` Scott Wood
@ 2015-11-05 23:16 ` Daniel Walker
2015-11-05 23:40 ` Scott Wood
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Walker @ 2015-11-05 23:16 UTC (permalink / raw)
To: Scott Wood
Cc: Jia Hongtao, Kumar Gala, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, linuxppc-dev, David Beazley (dbeazley),
xe-kernel@external.cisco.com
On 11/05/2015 03:12 PM, Scott Wood wrote:
> On Thu, 2015-11-05 at 10:48 -0800, Daniel Walker wrote:
>> Hi,
>>
>> 905e75c46dba5f3061049277e4eb7110beedba43:arch/powerpc/platforms/85xx/mpc85xx_ads.c
>>
>>
>> This commit seems to cause problems with PCI devices doing DMA, just
>> with mpc85xx ads. If you do the "fsl_add_bridge()" after you setup the
>> ppc_md.pci_exclude_device to mpc85xx_exclude_device, then the
>> early_read_config_word() calls in
>> arch/powerpc/sysdev/fsl_pci.c:setup_pci_cmd() are like no-ops.
>>
>> This issue was found by David Beazley (on the CC), he can respond to
>> more detailed questions on it. The fix he came up with was to remove the
>> "pci_exclude_device".
>>
>> Daniel
> OK, please send a patch.
>
I was hoping Jia Hongtao could address why it wasn't address in the
original patch. Some of the other boards also have an exclude function,
and I wonder if those work with this change.
Daniel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: powerpc/fsl-pci: Unify pci/pcie initialization code
2015-11-05 23:16 ` Daniel Walker
@ 2015-11-05 23:40 ` Scott Wood
0 siblings, 0 replies; 4+ messages in thread
From: Scott Wood @ 2015-11-05 23:40 UTC (permalink / raw)
To: Daniel Walker
Cc: Jia Hongtao, Kumar Gala, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, linuxppc-dev, David Beazley (dbeazley),
xe-kernel@external.cisco.com
On Thu, 2015-11-05 at 15:16 -0800, Daniel Walker wrote:
> On 11/05/2015 03:12 PM, Scott Wood wrote:
> > On Thu, 2015-11-05 at 10:48 -0800, Daniel Walker wrote:
> > > Hi,
> > >
> > > 905e75c46dba5f3061049277e4eb7110beedba43:arch/powerpc/platforms/85xx/mpc85xx_ads.c
> > >
> > >
> > >
> > > This commit seems to cause problems with PCI devices doing DMA, just
> > > with mpc85xx ads. If you do the "fsl_add_bridge()" after you setup the
> > > ppc_md.pci_exclude_device to mpc85xx_exclude_device, then the
> > > early_read_config_word() calls in
> > > arch/powerpc/sysdev/fsl_pci.c:setup_pci_cmd() are like no-ops.
> > >
> > > This issue was found by David Beazley (on the CC), he can respond to
> > > more detailed questions on it. The fix he came up with was to remove the
> > > "pci_exclude_device".
> > >
> > > Daniel
> > OK, please send a patch.
> >
>
> I was hoping Jia Hongtao could address why it wasn't address in the
> original patch. Some of the other boards also have an exclude function,
> and I wonder if those work with this change.
This is the only board I saw that excludes the host bridge. It wasn't
addressed because it wasn't noticed.
-Scott
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-05 23:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-05 18:48 powerpc/fsl-pci: Unify pci/pcie initialization code Daniel Walker
2015-11-05 23:12 ` Scott Wood
2015-11-05 23:16 ` Daniel Walker
2015-11-05 23:40 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).