From: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
Daniel Axtens <dja@axtens.net>,
linuxppc-dev@ozlabs.org
Cc: mikey@neuling.org, imunsie@au1.ibm.com
Subject: Re: [PATCH] cxl: use correct operator when writing pcie config space values
Date: Mon, 09 Nov 2015 17:45:25 +1100 [thread overview]
Message-ID: <56404105.1010302@au1.ibm.com> (raw)
In-Reply-To: <1446767022.25265.2.camel@ellerman.id.au>
On 06/11/15 10:43, Michael Ellerman wrote:
> If it's unused *and* broken then we should just remove it.
Following some discussion with Ian and Vaibhav, we'd like to keep it at
this stage - while there are no current AFUs which write to AFU config
space, it would be reasonable for an AFU developer to assume that AFU
config space is writable, and I am led to believe there is nothing in
the publicly available documentation that would suggest otherwise.
Ian is working on obtaining a test AFU with support for this, at which
point we will add it to our internal test suite.
As such I'd like to continue with the patch as is, I'm happy to drop the
stable Cc though.
Andrew
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnellan@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work) IBM Australia Limited
next prev parent reply other threads:[~2015-11-09 6:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 2:24 [PATCH] cxl: use correct operator when writing pcie config space values Andrew Donnellan
2015-11-04 4:07 ` Ian Munsie
2015-11-05 23:05 ` Daniel Axtens
2015-11-05 23:17 ` Michael Neuling
2015-11-05 23:17 ` Andrew Donnellan
2015-11-05 23:43 ` Michael Ellerman
2015-11-09 6:45 ` Andrew Donnellan [this message]
2015-11-12 2:26 ` Daniel Axtens
2015-11-26 12:15 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56404105.1010302@au1.ibm.com \
--to=andrew.donnellan@au1.ibm.com \
--cc=dja@axtens.net \
--cc=imunsie@au1.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).