From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mmarek@suse.com>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by lists.ozlabs.org (Postfix) with ESMTPS id B2C661A0202
 for <linuxppc-dev@lists.ozlabs.org>; Fri,  8 Jan 2016 06:44:46 +1100 (AEDT)
Subject: Re: Build failure: -Wno-unused-const-variable DNE on old GCC
To: Joe Perches <joe@perches.com>, Brian Norris
 <computersforpeace@gmail.com>, Michael Ellerman <mpe@ellerman.id.au>
References: <20160107185406.GA65420@google.com>
 <1452195444.4028.21.camel@perches.com>
Cc: Anton Blanchard <anton@au1.ibm.com>, Ian Munsie <imunsie@au1.ibm.com>,
 Michael Neuling <mikey@neuling.org>, linuxppc-dev@lists.ozlabs.org,
 linux-kernel@vger.kernel.org
From: Michal Marek <mmarek@suse.com>
Message-ID: <568EC026.2020207@suse.com>
Date: Thu, 7 Jan 2016 20:44:38 +0100
MIME-Version: 1.0
In-Reply-To: <1452195444.4028.21.camel@perches.com>
Content-Type: text/plain; charset=windows-1252
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev/>
List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>

Dne 7.1.2016 v 20:37 Joe Perches napsal(a):
> On Thu, 2016-01-07 at 10:54 -0800, Brian Norris wrote:
>> Hi,
>>
>> I'm using a GCC 4.6.3 compiler for some compile tests, and I noticed
>> that commit 2cd55c68c0a4 ("cxl: Fix build failure due to -Wunused-variable
>> behaviour change") breaks my builds, because the
>> -Wno-unused-const-variable doesn't exist on GCC 4.6.3.
>>
>>   drivers/misc/cxl/base.c: At top level:
>>   cc1: error: unrecognized command line option "-Wno-unused-const-variable" [-Werror]
>>
>> Any thoughts on how to best fix this? I'd like not to have to scrounge
>> up a new cross compiler just for build tests.
> 
> drivers/misc/cxl/Makefile:ccflags-y := -Werror -Wno-unused-const-variable
> 
> You could take that -Wno-unused-const-variable out of the
> Makefile or maybe add something like:
> 
> $(call cc-ifversion, -ge, 0530, -Wno-unused-const-variable)
> 
> or whatever gcc version actually added that unused-const-variable check

We have cc-disable-warning for this.

Michal