From: Alexander Graf <agraf@suse.de>
To: Julian Margetson <runaway@candw.ms>
Cc: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@lists.ozlabs.org
Subject: Re: commit 9178ba294b6839eeff1a91bed95515d783f3ee6c an A-Eon Tabor Board
Date: Wed, 3 Feb 2016 23:59:54 +0100 [thread overview]
Message-ID: <56B2866A.40202@suse.de> (raw)
In-Reply-To: <56B28509.2080303@candw.ms>
On 02/03/2016 11:54 PM, Julian Margetson wrote:
> On 2/3/2016 6:20 PM, Alexander Graf wrote:
>>
>>
>> On 02/03/2016 11:15 PM, Julian Margetson wrote:
>>> On 2/3/2016 4:43 PM, Alexander Graf wrote:
>>>>
>>>>
>>>> On 02/03/2016 10:33 AM, Julian Margetson wrote:
>>>>> Resending as it was attached to and old thread relating to a
>>>>> different motherboard.
>>>>>
>>>>> On 2/2/2016 9:54 AM, Julian Margetson wrote:
>>>>>>
>>>>>> Commit 9178ba294b6839eeff1a91bed95515d783f3ee6c prevents building
>>>>>> of kernel 4.1 branch on A-Eon Tabor Board.
>>>>>>
>>>>>> CC arch/powerpc/math-emu/fsqrt.o
>>>>>> arch/powerpc/platforms/85xx/tabor.c:194:2: error: unknown field
>>>>>> ‘power_off’ specified in initializer
>>>>
>>>> I can't seem to find that file in Linux upstream?
>>>>
>>>>
>>>> Alex
>>>>
>>>>
>>>>
>>>
>>> It may have been discontinued as the patches used were maintained
>>> along with patches for the (Varisys) A-Eon Cyrus board
>>> which is officially supported from kernel 4.4.
>>>
>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=c383ee84e1d575b09d167185d15df24bde25eb15
>>>
>>
>> I don't quite understand how an internal API change in Linux breaking
>> random external patches is a bug? Either your code is upstream or it
>> can break on every git commit done upstream.
>>
>>
>> Alex
>>
>>
>>
>
> Sorry I am relatively new at this.
> If I manage to pinpoint a problem on my powerpc machines I report it .
> Most of them so far have indeed been bugs.
> The random external patches were done by person with far greater
> competence than me who are no longer in the picture.
> Any guidance would be greatly appreciated.
I think the most important step really is to upstream board support,
otherwise things will continue to fall apart for sure.
As for the exact breakage you saw, just remove the line and put a line like
pm_power_off = tabor_power_off;
in your board probe function in tabor.c.
Alex
next prev parent reply other threads:[~2016-02-03 23:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 9:33 commit 9178ba294b6839eeff1a91bed95515d783f3ee6c an A-Eon Tabor Board Julian Margetson
2016-02-03 20:43 ` Alexander Graf
2016-02-03 22:15 ` Julian Margetson
2016-02-03 22:20 ` Alexander Graf
2016-02-03 22:54 ` Julian Margetson
2016-02-03 22:59 ` Alexander Graf [this message]
2016-02-03 23:08 ` Julian Margetson
2016-03-16 11:56 ` Julian Margetson
2016-03-16 22:09 ` Julian Margetson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B2866A.40202@suse.de \
--to=agraf@suse.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=runaway@candw.ms \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).