From: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
To: Joel Stanley <joel@jms.id.au>
Cc: Stewart Smith <stewart@linux.vnet.ibm.com>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH V2 1/2] powerpc/powernv: new function to access OPAL msglog
Date: Thu, 11 Feb 2016 18:31:40 +1100 [thread overview]
Message-ID: <56BC38DC.9090301@au1.ibm.com> (raw)
In-Reply-To: <CACPK8Xcfi+8XAR3WxvP6qJ7YjSBprZNcMzKrtiaABgoGw015gw@mail.gmail.com>
On 11/02/16 18:14, Joel Stanley wrote:
> Looks like you didn't break it much. Congratulations on being the new
> memcons maintainer!
Argh, I forgot the golden rule of kernel development - if you touch it,
you own it... :)
> There's one issue with your error handling.
>
>> diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
>> index 4e0da5a..0256d07 100644
>> --- a/arch/powerpc/platforms/powernv/opal.c
>> +++ b/arch/powerpc/platforms/powernv/opal.c
>> @@ -724,6 +724,9 @@ static int __init opal_init(void)
>> of_node_put(leds);
>> }
>>
>> + /* Initialise OPAL message log interface */
>> + opal_msglog_init();
>
> If this fails due to eg. the magic number being wrong.
>
>> +
>> /* Create "opal" kobject under /sys/firmware */
>> rc = opal_sysfs_init();
>> if (rc == 0) {
>> @@ -739,8 +742,8 @@ static int __init opal_init(void)
>> opal_platform_dump_init();
>> /* Setup system parameters interface */
>> opal_sys_param_init();
>> - /* Setup message log interface. */
>> - opal_msglog_init();
>> + /* Setup message log sysfs interface. */
>> + opal_msglog_sysfs_init();
>
> This will succeed, leaving you with a sysfs file attached to a broken driver.
V3 on its way...
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnellan@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work) IBM Australia Limited
next prev parent reply other threads:[~2016-02-11 7:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 7:17 [PATCH V2 1/2] powerpc/powernv: new function to access OPAL msglog Andrew Donnellan
2016-02-09 7:17 ` [PATCH V2 2/2] powerpc/xmon: add command to dump " Andrew Donnellan
2016-02-11 14:15 ` Denis Kirjanov
2016-02-17 12:41 ` [V2,2/2] " Michael Ellerman
2016-02-11 6:32 ` [PATCH V2 1/2] powerpc/powernv: new function to access " Stewart Smith
2016-02-11 7:14 ` Joel Stanley
2016-02-11 7:31 ` Andrew Donnellan [this message]
2016-02-11 7:36 ` [PATCH V3 " Andrew Donnellan
2016-02-11 7:36 ` [PATCH V3 2/2] powerpc/xmon: add command to dump " Andrew Donnellan
2016-02-11 22:30 ` [PATCH V3 1/2] powerpc/powernv: new function to access " Joel Stanley
2016-02-17 12:41 ` [V2,1/2] " Michael Ellerman
2016-02-18 1:17 ` Andrew Donnellan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BC38DC.9090301@au1.ibm.com \
--to=andrew.donnellan@au1.ibm.com \
--cc=joel@jms.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=stewart@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).