From: Douglas Miller <dougmill@linux.vnet.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC, kernel] powerpc/ioda: Set "read" permission when "write" is set
Date: Tue, 16 Feb 2016 07:20:34 -0600 [thread overview]
Message-ID: <56C32222.6050704@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160216031824.E5C8E140761@ozlabs.org>
On 02/15/2016 09:18 PM, Michael Ellerman wrote:
> On Tue, 2016-12-01 at 04:40:20 UTC, Alexey Kardashevskiy wrote:
>> Quite often drivers set only "write" permission assuming that this
>> includes "read" permission as well and this works on plenty platforms.
>> However IODA2 is strict about this and produces an EEH when "read"
>> permission is not and reading happens.
>>
>> This adds a workaround in IODA code to always add the "read" bit when
>> the "write" bit is set.
>>
>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> Tested-by: Douglas Miller <dougmill@linux.vnet.ibm.com>
> Are you planning on sending a non-RFC version of this?
>
> If so is it an urgent fix I should send upstream now? And if so should it
> also be CC'ed to stable?
>
> cheers
I vote for the more-urgent case. This is the result of a fairly recent
change in behavior and we may not have found all the adapters that will
break yet. If we get this upstream sooner, it means less exposure.
next prev parent reply other threads:[~2016-02-16 13:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 4:40 [RFC PATCH kernel] powerpc/ioda: Set "read" permission when "write" is set Alexey Kardashevskiy
2016-01-12 23:07 ` Benjamin Herrenschmidt
2016-01-13 2:24 ` Douglas Miller
2016-01-19 3:52 ` Alexey Kardashevskiy
2016-01-19 19:01 ` Douglas Miller
2016-02-09 1:37 ` Alexey Kardashevskiy
2016-02-09 14:28 ` Douglas Miller
2016-02-10 0:32 ` Alexey Kardashevskiy
2016-02-10 12:26 ` Douglas Miller
2016-02-16 3:18 ` [RFC, " Michael Ellerman
2016-02-16 13:20 ` Douglas Miller [this message]
2016-02-17 7:29 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C32222.6050704@linux.vnet.ibm.com \
--to=dougmill@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).