From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp08.au.ibm.com (e23smtp08.au.ibm.com [202.81.31.141]) (using TLSv1.2 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 7FD171A2D74 for ; Wed, 17 Feb 2016 15:19:42 +1100 (AEDT) Received: from localhost by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 17 Feb 2016 14:19:41 +1000 Received: from d23relay07.au.ibm.com (d23relay07.au.ibm.com [9.190.26.37]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 3C7293578056 for ; Wed, 17 Feb 2016 15:19:40 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay07.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u1H4JWAE7733504 for ; Wed, 17 Feb 2016 15:19:40 +1100 Received: from d23av03.au.ibm.com (localhost [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u1H4J7O2032468 for ; Wed, 17 Feb 2016 15:19:07 +1100 Subject: Re: [PATCH v8 03/45] powerpc/pci: Cleanup on struct pci_controller_ops To: Gavin Shan , linuxppc-dev@lists.ozlabs.org References: <1455680668-23298-1-git-send-email-gwshan@linux.vnet.ibm.com> <1455680668-23298-4-git-send-email-gwshan@linux.vnet.ibm.com> Cc: devicetree@vger.kernel.org, aik@ozlabs.ru, linux-pci@vger.kernel.org, grant.likely@linaro.org, robherring2@gmail.com, bhelgaas@google.com, dja@axtens.net From: Andrew Donnellan Message-ID: <56C3F4A2.1010909@au1.ibm.com> Date: Wed, 17 Feb 2016 15:18:42 +1100 MIME-Version: 1.0 In-Reply-To: <1455680668-23298-4-git-send-email-gwshan@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 17/02/16 14:43, Gavin Shan wrote: > Each PHB has one instance of "struct pci_controller_ops", which > includes various callbacks called by PCI subsystem. In the definition > of this struct, some callbacks have explicit names for its arguments, > but the left don't have. > > This adds all explicit names of the arguments to the callbacks in > "struct pci_controller_ops" so that the code looks consistent. > > Signed-off-by: Gavin Shan > Reviewed-by: Daniel Axtens Reviewed-by: Andrew Donnellan -- Andrew Donnellan Software Engineer, OzLabs andrew.donnellan@au1.ibm.com Australia Development Lab, Canberra +61 2 6201 8874 (work) IBM Australia Limited