From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e31.co.us.ibm.com (e31.co.us.ibm.com [32.97.110.149]) (using TLSv1.2 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 8F3991A0900 for ; Mon, 22 Feb 2016 08:45:40 +1100 (AEDT) Received: from localhost by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 21 Feb 2016 14:45:38 -0700 Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id B11023E40030 for ; Sun, 21 Feb 2016 14:45:36 -0700 (MST) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u1LLjaI035979470 for ; Sun, 21 Feb 2016 14:45:36 -0700 Received: from d03av01.boulder.ibm.com (localhost [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u1LLjaqc014689 for ; Sun, 21 Feb 2016 14:45:36 -0700 Reply-To: manoj@linux.vnet.ibm.com Subject: Re: Fwd: [PATCH v4 03/18] cxl: Define process problem state area at attach time only References: <1455658751-16970-4-git-send-email-fbarrat@linux.vnet.ibm.com> <56CA2C87.7040905@linux.vnet.ibm.com> To: fbarrat@linux.vnet.ibm.com Cc: Ian Munsie , michael.neuling1@au1.ibm.com, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org From: Manoj Kumar Message-ID: <56CA3012.1000205@linux.vnet.ibm.com> Date: Sun, 21 Feb 2016 15:45:54 -0600 MIME-Version: 1.0 In-Reply-To: <56CA2C87.7040905@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reviewed-by: Manoj Kumar --- Manoj Kumar > Subject: [PATCH v4 03/18] cxl: Define process problem state area at > attach time only > Date: Tue, 16 Feb 2016 22:38:56 +0100 > From: Frederic Barrat > To: imunsie@au1.ibm.com, michael.neuling@au1.ibm.com, > mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org > > Cxl kernel API was defining the process problem state area during Suggestion: Cxl -> CXL > context initialization, making it possible to map the problem state > area before attaching the context. This won't work on a powerVM > guest. So force the logical behavior, like in userspace: attach first, > then map the problem state area. > Remove calls to cxl_assign_psn_space during init. The function is > already called on the attach paths. > > Co-authored-by: Christophe Lombard > Signed-off-by: Frederic Barrat > Signed-off-by: Christophe Lombard > --- > drivers/misc/cxl/api.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c > index ea3eeb7..b45d857 100644 > --- a/drivers/misc/cxl/api.c > +++ b/drivers/misc/cxl/api.c > @@ -51,8 +51,6 @@ struct cxl_context *cxl_dev_context_init(struct > pci_dev *dev) > if (rc) > goto err_mapping; > > - cxl_assign_psn_space(ctx); > - > return ctx; > > err_mapping: > @@ -207,7 +205,6 @@ EXPORT_SYMBOL_GPL(cxl_stop_context); > void cxl_set_master(struct cxl_context *ctx) > { > ctx->master = true; > - cxl_assign_psn_space(ctx); > } > EXPORT_SYMBOL_GPL(cxl_set_master); > > @@ -325,15 +322,11 @@ EXPORT_SYMBOL_GPL(cxl_start_work); > > void __iomem *cxl_psa_map(struct cxl_context *ctx) > { > - struct cxl_afu *afu = ctx->afu; > - int rc; > - > - rc = cxl_afu_check_and_enable(afu); > - if (rc) > + if (ctx->status != STARTED) > return NULL; > > pr_devel("%s: psn_phys%llx size:%llx\n", > - __func__, afu->psn_phys, afu->adapter->ps_size); > + __func__, ctx->psn_phys, ctx->psn_size); > return ioremap(ctx->psn_phys, ctx->psn_size); > } > EXPORT_SYMBOL_GPL(cxl_psa_map);