From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>,
kirill.shutemov@linux.intel.com, Hugh Dickins <hughd@google.com>
Cc: Linux PPC dev <linuxppc-dev@ozlabs.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Question on follow_page_mask
Date: Tue, 23 Feb 2016 18:45:05 +0530 [thread overview]
Message-ID: <56CC5B59.4030902@linux.vnet.ibm.com> (raw)
Not able to understand the first code block of follow_page_mask
function. follow_huge_addr function is expected to find the page
struct for the given address if it turns out to be a HugeTLB page
but then when it finds the page we bug on if it had been called
with FOLL_GET flag.
page = follow_huge_addr(mm, address, flags & FOLL_WRITE);
if (!IS_ERR(page)) {
BUG_ON(flags & FOLL_GET);
return page;
}
do_move_page_to_node_array calls follow_page with FOLL_GET which
in turn calls follow_page_mask with FOLL_GET. On POWER, the
function follow_huge_addr is defined and does not return -EINVAL
like the generic one. It returns the page struct if its a HugeTLB
page. Just curious to know what is the purpose behind the BUG_ON.
Thank you.
Regards
Anshuman
next reply other threads:[~2016-02-23 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 13:15 Anshuman Khandual [this message]
2016-02-23 14:03 ` Question on follow_page_mask Kirill A. Shutemov
2016-02-23 21:07 ` Hugh Dickins
2016-02-24 11:45 ` Anshuman Khandual
2016-02-24 11:22 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC5B59.4030902@linux.vnet.ibm.com \
--to=khandual@linux.vnet.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).