From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151]) (using TLSv1.2 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 6DEE21A0F7B for ; Wed, 24 Feb 2016 06:13:42 +1100 (AEDT) Received: from localhost by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 23 Feb 2016 12:13:40 -0700 Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 9158119D8040 for ; Tue, 23 Feb 2016 12:01:21 -0700 (MST) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u1NJDO3926804378 for ; Tue, 23 Feb 2016 12:13:24 -0700 Received: from d03av03.boulder.ibm.com (localhost [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u1NJDOMS012719 for ; Tue, 23 Feb 2016 12:13:24 -0700 Received: from [9.41.250.246] (manoj.austin.ibm.com [9.41.250.246]) by d03av03.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u1NJDOql012680 for ; Tue, 23 Feb 2016 12:13:24 -0700 Reply-To: manoj@linux.vnet.ibm.com Subject: Re: [PATCH v5 07/18] cxl: Update cxl_irq() prototype References: <1456244519-18934-1-git-send-email-fbarrat@linux.vnet.ibm.com> <1456244519-18934-8-git-send-email-fbarrat@linux.vnet.ibm.com> To: linuxppc-dev@lists.ozlabs.org From: Manoj Kumar Message-ID: <56CCAF69.9010401@linux.vnet.ibm.com> Date: Tue, 23 Feb 2016 13:13:45 -0600 MIME-Version: 1.0 In-Reply-To: <1456244519-18934-8-git-send-email-fbarrat@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reviewed-by: Manoj Kumar --- Manoj Kumar On 2/23/2016 10:21 AM, Frederic Barrat wrote: > The context parameter when calling cxl_irq() should be strongly typed. > > Co-authored-by: Christophe Lombard > Signed-off-by: Frederic Barrat > Signed-off-by: Christophe Lombard > Acked-by: Ian Munsie > --- > drivers/misc/cxl/cxl.h | 2 +- > drivers/misc/cxl/irq.c | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/misc/cxl/cxl.h b/drivers/misc/cxl/cxl.h > index 40f6783..c7ed265 100644 > --- a/drivers/misc/cxl/cxl.h > +++ b/drivers/misc/cxl/cxl.h > @@ -714,7 +714,7 @@ struct cxl_irq_info { > }; > > void cxl_assign_psn_space(struct cxl_context *ctx); > -irqreturn_t cxl_irq(int irq, void *ctx, struct cxl_irq_info *irq_info); > +irqreturn_t cxl_irq(int irq, struct cxl_context *ctx, struct cxl_irq_info *irq_info); > int cxl_register_one_irq(struct cxl *adapter, irq_handler_t handler, > void *cookie, irq_hw_number_t *dest_hwirq, > unsigned int *dest_virq, const char *name); > diff --git a/drivers/misc/cxl/irq.c b/drivers/misc/cxl/irq.c > index 56ad301..5033869 100644 > --- a/drivers/misc/cxl/irq.c > +++ b/drivers/misc/cxl/irq.c > @@ -27,9 +27,8 @@ static irqreturn_t schedule_cxl_fault(struct cxl_context *ctx, u64 dsisr, u64 da > return IRQ_HANDLED; > } > > -irqreturn_t cxl_irq(int irq, void *data, struct cxl_irq_info *irq_info) > +irqreturn_t cxl_irq(int irq, struct cxl_context *ctx, struct cxl_irq_info *irq_info) > { > - struct cxl_context *ctx = data; > u64 dsisr, dar; > > dsisr = irq_info->dsisr; >