linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
To: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>,
	Ian Munsie <imunsie@au1.ibm.com>,
	Michael Ellerman <michaele@au1.ibm.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Matt Ochs <mrochs@us.ibm.com>, Manoj Kumar <kumarmn@us.ibm.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
	Michael Neuling <mikey@neuling.org>
Subject: Re: [PATCH v3 1/2] cxl: Add mechanism for delivering AFU driver specific events
Date: Wed, 9 Mar 2016 18:08:06 +0100	[thread overview]
Message-ID: <56E05876.6090006@linux.vnet.ibm.com> (raw)
In-Reply-To: <87a8m7iunv.fsf@vajain21.in.ibm.com>

Hi Vaibhav,

Le 09/03/2016 15:37, Vaibhav Jain a écrit :

> I would propose these two apis.
>
> /*
> *  fetches an event from the driver event queue. NULL means that queue
> *  is empty. Can sleep if needed. The memory for cxl_event is allocated
> *  by module being called. Hence it can be potentially be larger then
> *  sizeof(struct cxl_event). Multiple calls to this should return same
> *  pointer untill ack_event is called.
> */
> struct cxl_event * fetch_event(struct cxl_context * ctx);
>
> /*
> * Returns and acknowledge the struct cxl_event * back to the driver
> * which can then free it or maybe put it back in a kmem_cache. This
> * should be called once we have completely returned the current
> * struct cxl_event from the readcall
> */
> void ack_event(struct cxl_context * ctx, struct cxl_event *);


How would you implement polling on those APIs?
How would you implement afu_read? There are several sources of events.

   Fred

  parent reply	other threads:[~2016-03-09 17:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08  1:48 [PATCH v3 1/2] cxl: Add mechanism for delivering AFU driver specific events Ian Munsie
2016-03-08  1:48 ` [PATCH v3 2/2] cxl: add set/get private data to context struct Ian Munsie
2016-03-08  7:59   ` Andrew Donnellan
2016-03-08  4:06 ` [PATCH v3 1/2] cxl: Add mechanism for delivering AFU driver specific events Matt Ochs
2016-03-08  7:59 ` Andrew Donnellan
2016-03-09  9:27 ` Frederic Barrat
2016-03-10  0:46   ` Ian Munsie
2016-03-10  1:26   ` Ian Munsie
2016-03-09 14:37 ` Vaibhav Jain
2016-03-09 16:41   ` Matt Ochs
2016-03-09 17:08   ` Frederic Barrat [this message]
2016-03-10 17:19     ` Vaibhav Jain
2016-03-10  1:18   ` Ian Munsie
2016-03-10 17:39     ` Vaibhav Jain
2016-03-11  1:48     ` Andrew Donnellan
2016-03-10  3:24   ` Michael Neuling
2016-03-10 17:23     ` Vaibhav Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E05876.6090006@linux.vnet.ibm.com \
    --to=fbarrat@linux.vnet.ibm.com \
    --cc=imunsie@au1.ibm.com \
    --cc=kumarmn@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=michaele@au1.ibm.com \
    --cc=mikey@neuling.org \
    --cc=mrochs@us.ibm.com \
    --cc=vaibhav@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).