From: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
To: Russell Currey <ruscur@russell.cc>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powernv/hmi: Use the "unknown" checkstop type as a fallback
Date: Tue, 15 Mar 2016 14:56:46 +1100 [thread overview]
Message-ID: <56E787FE.1060104@au1.ibm.com> (raw)
In-Reply-To: <1458012409-32448-1-git-send-email-ruscur@russell.cc>
On 15/03/16 14:26, Russell Currey wrote:
> The HMI code knows about three types of errors: CORE, NX and UNKNOWN.
> If OPAL were to add a new type, it would not be handled at all since
> there is no fallback case. Instead of explicitly checking for UNKNOWN,
> treat any checkstop type without a handler as unknown.
>
> Signed-off-by: Russell Currey <ruscur@russell.cc>
Indeed it looks like there isn't a fallback case.
Would it be useful to print xstop_type in the unknown case?
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnellan@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work) IBM Australia Limited
next prev parent reply other threads:[~2016-03-15 3:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 3:26 [PATCH] powernv/hmi: Use the "unknown" checkstop type as a fallback Russell Currey
2016-03-15 3:41 ` Daniel Axtens
2016-03-15 3:56 ` Andrew Donnellan [this message]
2016-03-15 5:15 ` Russell Currey
2016-03-15 5:36 ` Andrew Donnellan
2016-03-15 5:40 ` Russell Currey
2016-03-15 9:28 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E787FE.1060104@au1.ibm.com \
--to=andrew.donnellan@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).