From: Balbir Singh <bsingharora@gmail.com>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/mm: Remove long disabled SLB code
Date: Thu, 17 Mar 2016 10:54:57 +1100 [thread overview]
Message-ID: <56E9F251.7070005@gmail.com> (raw)
In-Reply-To: <1458125780-22841-1-git-send-email-mpe@ellerman.id.au>
On 16/03/16 21:56, Michael Ellerman wrote:
> We have a bunch of SLB related code in the tree which is there to handle
> dynamic VSIDs - but currently it's all disabled at compile time. The
> comments say "Keep that around for when we re-implement dynamic VSIDs".
>
> But that was over 10 years ago (commit 3c726f8dee6f ("[PATCH] ppc64:
> support 64k pages")). The chance that it would still work unchanged is
> minimal, and in the meantime it's confusing to folks browsing/grepping
> the code. If we ever want to re-instate it, it's in the git history.
and older kernels :)
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>
Makes sense, given that none of the code is exercised, it makes sense to remove it or keep it tested and updated. Removal makes more sense
Acked-by: Balbir Singh <bsingharora@gmail.com>
next prev parent reply other threads:[~2016-03-16 23:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 10:56 [PATCH] powerpc/mm: Remove long disabled SLB code Michael Ellerman
2016-03-16 23:54 ` Balbir Singh [this message]
2016-04-11 12:35 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E9F251.7070005@gmail.com \
--to=bsingharora@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).