From: Segher Boessenkool <segher@kernel.crashing.org>
To: Wade Farnsworth <wfarnsworth@mvista.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>, paulus@samba.org
Subject: Re: [PATCH] Fix the LPC47M192 SuperIO on the MPC8641 HPCN
Date: Thu, 7 Jun 2007 19:04:10 +0200 [thread overview]
Message-ID: <56b6143f7a188370557f3407c5a356c9@kernel.crashing.org> (raw)
In-Reply-To: <1181234565.5674.182.camel@rhino>
>>> + /* enable superio @ 0x4e and keyboard/mouse address decoding */
>>> + pci_write_config_byte(dev, 0x63, 0x90);
>>
>> I doubt that comment is accurate.
>
> m1575 legacy interface device register 0x63 is the legacy I/O decoding
> control.
>
> Writing 0x90 enables ports 0x4e and 0x4f for Super I/O configuration
> and
> ports 0x60 and 0x64 for keyboard/mouse.
Ah I see. Copy this explanation into your next
version of the patch? :-)
Segher
prev parent reply other threads:[~2007-06-07 17:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 16:30 [PATCH] Fix the LPC47M192 SuperIO on the MPC8641 HPCN Wade Farnsworth
2007-06-06 22:39 ` Arnd Bergmann
2007-06-07 13:03 ` Segher Boessenkool
2007-06-07 16:04 ` Wade Farnsworth
2007-06-07 16:35 ` Segher Boessenkool
2007-06-07 16:51 ` Wade Farnsworth
2007-06-07 17:05 ` Segher Boessenkool
2007-06-07 20:01 ` Andy Fleming
2007-06-08 8:22 ` Segher Boessenkool
2007-06-07 13:01 ` Segher Boessenkool
2007-06-07 16:42 ` Wade Farnsworth
2007-06-07 17:04 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56b6143f7a188370557f3407c5a356c9@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=wfarnsworth@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).