LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Harsh Prateek Bora <harshpb@linux.ibm.com>
To: Madhavan Srinivasan <maddy@linux.ibm.com>,
	Vaibhav Jain <vaibhav@linux.ibm.com>,
	Ritesh Harjani <ritesh.list@gmail.com>,
	Amit Machhiwal <amachhiw@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org,
	Anushree Mathur <anushree.mathur@linux.ibm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, lkp@intel.com
Subject: Re: [PATCH v3 1/5] KVM: PPC: Book3S HV: Validate arch_compat against host compatibility mode
Date: Wed, 3 Jun 2026 10:40:39 +0530	[thread overview]
Message-ID: <56c84e26-69ed-433b-baaf-7b53acc60391@linux.ibm.com> (raw)
In-Reply-To: <72ef4cdb-8d9e-4319-9c94-b9a46a6f6194@linux.ibm.com>



On 03/06/26 10:03 am, Madhavan Srinivasan wrote:
> 
> On 6/3/26 9:03 AM, Vaibhav Jain wrote:
>> Hi Ritesh, thanks for looking into this patch. My responses to your
>> review comments inline below.
>>
>> Ritesh Harjani (IBM) <ritesh.list@gmail.com> writes:
>>
>>> Amit Machhiwal <amachhiw@linux.ibm.com> writes:
>>>
>>>> So, we would still want to prioritize the whole series
>>>> instead of just this one patch.
>>>>
>>> Patch-1 could go as a bug fix even in 7.1-rc6 (or maybe with 7.2
>>> bug fixes). - Maddy?
>>>
>>> So, you may want to add a fixes tag and maybe even cc stable if you are
>>> seeing this issue from older kernels maybe when nestedv2 got introduced?
>> This isnt a 'bug fix' per-se but rather strengthening of compat mode
>> checks so that any non compatible PVR being used by the VMM can be
>> caught early. The hypervisor anyway ultimately prevents non-compatible
>> PVRs from being used by the VMM. So there isnt a bug thats being fixed
>> in this patch.
>>
>> The rest of the patch series builds on top of this patch to advertise
>> the available compatible PVRs to the VMM so that it can further
>> preemptively prevent users from forcibly using a non-compatible PVR.
>>
>> Hence IMHO, this patch can be marked for stable tree and potential
>> candidate for 7.2 merge window. But dont see applicability of a 'fixes'
>> tag to this patch
> amit, can you just post this alone as a separate patch, so that we could
> pull it for 7.2 merge?
> 

FWIW, b4 am -P1 <mbox> should fetch this patch alone (and not the entire 
series), See b4 am --help for more options to select a subset of patches.

regards,
Harsh>
>>> However the new UAPI discussion might still require more discussion with
>>> the community and I don't think it is ready for 7.2 yet ;)
>> Somewhat agree with the above
>>
>>> -ritesh
>>>
> 



  reply	other threads:[~2026-06-03  5:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22 15:27 [PATCH v3 0/5] KVM: PPC: Handle CPU compatibility mode for nested guests Amit Machhiwal
2026-05-22 15:27 ` [PATCH v3 1/5] KVM: PPC: Book3S HV: Validate arch_compat against host compatibility mode Amit Machhiwal
2026-05-28  3:13   ` Ritesh Harjani
2026-05-29 10:28     ` Amit Machhiwal
2026-05-29 11:53       ` Ritesh Harjani
2026-06-03  3:33         ` Vaibhav Jain
2026-06-03  4:33           ` Madhavan Srinivasan
2026-06-03  5:10             ` Harsh Prateek Bora [this message]
2026-06-03  6:05               ` Ritesh Harjani
2026-06-03  6:31                 ` Harsh Prateek Bora
2026-06-03 14:26                 ` Amit Machhiwal
2026-05-22 15:27 ` [PATCH v3 2/5] KVM: PPC: Introduce KVM_CAP_PPC_COMPAT_CAPS and wire up ioctl Amit Machhiwal
2026-06-03  3:46   ` Vaibhav Jain
2026-05-22 15:27 ` [PATCH v3 3/5] KVM: PPC: Book3S HV: Implement compat CPU capability retrieval for KVM on PowerVM Amit Machhiwal
2026-06-03  4:01   ` Vaibhav Jain
2026-05-22 15:27 ` [PATCH v3 4/5] KVM: PPC: Book3S HV: Add support for compat CPU capabilities for KVM on PowerNV Amit Machhiwal
2026-06-03  4:17   ` Vaibhav Jain
2026-05-22 15:27 ` [PATCH v3 5/5] KVM: PPC: Document KVM_PPC_GET_COMPAT_CAPS ioctl Amit Machhiwal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56c84e26-69ed-433b-baaf-7b53acc60391@linux.ibm.com \
    --to=harshpb@linux.ibm.com \
    --cc=amachhiw@linux.ibm.com \
    --cc=anushree.mathur@linux.ibm.com \
    --cc=chleroy@kernel.org \
    --cc=corbet@lwn.net \
    --cc=kvm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lkp@intel.com \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=ritesh.list@gmail.com \
    --cc=skhan@linuxfoundation.org \
    --cc=vaibhav@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox