From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-x231.google.com (mail-pf0-x231.google.com [IPv6:2607:f8b0:400e:c00::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3qvCdc5z4WzDqBH for ; Tue, 26 Apr 2016 16:20:52 +1000 (AEST) Received: by mail-pf0-x231.google.com with SMTP id 206so2881466pfu.0 for ; Mon, 25 Apr 2016 23:20:52 -0700 (PDT) Subject: Re: [PATCH V2 55/68] powerpc/mm: VMALLOC abstraction To: "Aneesh Kumar K.V" , Michael Neuling , benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au References: <1460182444-2468-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1460182444-2468-56-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1461307925.32306.46.camel@neuling.org> <87h9etypdu.fsf@skywalker.in.ibm.com> Cc: linuxppc-dev@lists.ozlabs.org From: Balbir Singh Message-ID: <571F08BB.5010906@gmail.com> Date: Tue, 26 Apr 2016 16:20:43 +1000 MIME-Version: 1.0 In-Reply-To: <87h9etypdu.fsf@skywalker.in.ibm.com> Content-Type: text/plain; charset=utf-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 23/04/16 13:29, Aneesh Kumar K.V wrote: > Michael Neuling writes: > >> Aneesh, >> >> I'm not sure why we need this patch. >> >> It seems to be moving the initialisation of some global variables into >> init functions from the definitions. And renames some things. > > > because the value to which it is getting initialized is no more a > constant. > Isn't it still a constant depending on the type of page table? Or is it a run time value depending on the chosen page table type? Balbir Singh