From: Frank Rowand <frowand.list@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Grant Likely <grant.likely@secretlab.ca>,
David Gibson <david@gibson.dropbear.id.au>,
"devicetree-spec@vger.kernel.org"
<devicetree-spec@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: case sensitivity for devicetree node names
Date: Sun, 12 Jun 2016 11:39:37 -0700 [thread overview]
Message-ID: <575DAC69.5010804@gmail.com> (raw)
In-Reply-To: <1465682743.19533.18.camel@kernel.crashing.org>
On 06/11/16 15:05, Benjamin Herrenschmidt wrote:
> On Sat, 2016-06-11 at 12:38 -0700, Frank Rowand wrote:
>> I chased through the history and found a 2.6.0-test5 announcement
>> which noted the patch from you which adds:
>>
>> of_find_node_by_path()
>> of_find_node_by_name()
>> of_find_node_by_type()
>> of_find_compatible_node()
>>
>> (And the patch is commit 394edd852a14 in the git recreation
>> of bitkeeper days, which is found at
>> git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git)
>>
>> That version of the functions uses a case insensitive compare for
>> devicetree node names.
>>
>> Do you remember why you chose to not use a case sensitive compare?
>
>>From memory, there were inconsistency in case on various earlier
> machines (notably old macs). I think that's the main reason.
>
> Cheers,
> Ben.
Is there a kernel config option (or a small set of config options)
that would identify the affected machines? It would be ok if
the option(s) also included some non-affected machines. That
way we could use the case insensitive compare for a small
set of machines.
next prev parent reply other threads:[~2016-06-12 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <575B1D84.2010703@gmail.com>
2016-06-11 19:38 ` case sensitivity for devicetree node names Frank Rowand
2016-06-11 22:05 ` Benjamin Herrenschmidt
2016-06-12 18:39 ` Frank Rowand [this message]
2016-06-12 21:56 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575DAC69.5010804@gmail.com \
--to=frowand.list@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree-spec@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).