* [PATCH] powerpc/fadump: trivial fix of spelling mistake, clean up message @ 2016-06-24 17:43 Colin King 2016-06-26 4:19 ` Michael Ellerman 0 siblings, 1 reply; 8+ messages in thread From: Colin King @ 2016-06-24 17:43 UTC (permalink / raw) To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman, Jiri Kosina, Rasmus Villemoes, Andrew Morton, linuxppc-dev Cc: linux-kernel From: Colin Ian King <colin.king@canonical.com> trivial fix to spelling mistake "rgistration" and minor clean up of the printk error message Signed-off-by: Colin Ian King <colin.king@canonical.com> --- arch/powerpc/kernel/fadump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c index 3cb3b02a..0358f5b 100644 --- a/arch/powerpc/kernel/fadump.c +++ b/arch/powerpc/kernel/fadump.c @@ -1010,7 +1010,7 @@ static int fadump_invalidate_dump(struct fadump_mem_struct *fdm) if (rc) { printk(KERN_ERR "Failed to invalidate firmware-assisted dump " - "rgistration. unexpected error(%d).\n", rc); + "registration. Unexpected error (%d).\n", rc); return rc; } fw_dump.dump_active = 0; -- 2.8.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: powerpc/fadump: trivial fix of spelling mistake, clean up message 2016-06-24 17:43 [PATCH] powerpc/fadump: trivial fix of spelling mistake, clean up message Colin King @ 2016-06-26 4:19 ` Michael Ellerman 2016-06-27 10:38 ` Colin Ian King 0 siblings, 1 reply; 8+ messages in thread From: Michael Ellerman @ 2016-06-26 4:19 UTC (permalink / raw) To: Colin King, Benjamin Herrenschmidt, Paul Mackerras, Jiri Kosina, Rasmus Villemoes, Andrew Morton, linuxppc-dev Cc: linux-kernel On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > trivial fix to spelling mistake "rgistration" and minor clean up > of the printk error message Can you also: - use pr_err() - unsplit the message, ie. keep the string all on one line. cheers ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: powerpc/fadump: trivial fix of spelling mistake, clean up message 2016-06-26 4:19 ` Michael Ellerman @ 2016-06-27 10:38 ` Colin Ian King 2016-06-27 10:51 ` Joe Perches 0 siblings, 1 reply; 8+ messages in thread From: Colin Ian King @ 2016-06-27 10:38 UTC (permalink / raw) To: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras, Jiri Kosina, Rasmus Villemoes, Andrew Morton, linuxppc-dev Cc: linux-kernel On 26/06/16 05:19, Michael Ellerman wrote: > On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> trivial fix to spelling mistake "rgistration" and minor clean up >> of the printk error message > > Can you also: > - use pr_err() > - unsplit the message, ie. keep the string all on one line. I can unsplit the string, but checkpatch will complain about that, so I'm not sure if that's preferred or not. WARNING: line over 80 characters Colin ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: powerpc/fadump: trivial fix of spelling mistake, clean up message 2016-06-27 10:38 ` Colin Ian King @ 2016-06-27 10:51 ` Joe Perches 2016-06-27 11:20 ` Michael Ellerman 0 siblings, 1 reply; 8+ messages in thread From: Joe Perches @ 2016-06-27 10:51 UTC (permalink / raw) To: Colin Ian King, Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras, Jiri Kosina, Rasmus Villemoes, Andrew Morton, linuxppc-dev Cc: linux-kernel On Mon, 2016-06-27 at 11:38 +0100, Colin Ian King wrote: > On 26/06/16 05:19, Michael Ellerman wrote: > > On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote: [] > > > trivial fix to spelling mistake "rgistration" and minor clean up > > > of the printk error message > > Can you also: > > - use pr_err() > > - unsplit the message, ie. keep the string all on one line. > I can unsplit the string, but checkpatch will complain about that, so > I'm not sure if that's preferred or not. > > WARNING: line over 80 characters If the statement is wrapped after the format, then checkpatch shouldn't complain. pr_err("Failed to invalidate firmware-assisted dump registration. Unexpected error (%d).\n", rc); ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: powerpc/fadump: trivial fix of spelling mistake, clean up message 2016-06-27 10:51 ` Joe Perches @ 2016-06-27 11:20 ` Michael Ellerman 2016-06-27 11:33 ` Joe Perches 2016-06-27 11:34 ` Colin Ian King 0 siblings, 2 replies; 8+ messages in thread From: Michael Ellerman @ 2016-06-27 11:20 UTC (permalink / raw) To: Joe Perches, Colin Ian King, Benjamin Herrenschmidt, Paul Mackerras, Jiri Kosina, Rasmus Villemoes, Andrew Morton, linuxppc-dev Cc: linux-kernel On Mon, 2016-06-27 at 03:51 -0700, Joe Perches wrote: > On Mon, 2016-06-27 at 11:38 +0100, Colin Ian King wrote: > > On 26/06/16 05:19, Michael Ellerman wrote: > > > On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote: > > > > trivial fix to spelling mistake "rgistration" and minor clean up > > > > of the printk error message > > > Can you also: > > > - use pr_err() > > > - unsplit the message, ie. keep the string all on one line. > > I can unsplit the string, but checkpatch will complain about that, so > > I'm not sure if that's preferred or not. > > > > WARNING: line over 80 characters > > If the statement is wrapped after the format, > then checkpatch shouldn't complain. > > pr_err("Failed to invalidate firmware-assisted dump registration. Unexpected error (%d).\n", > rc); But that's not actually any more readable, so just ignore checkpatch in this case IMHO. It's a guide, not the gospel. cheers ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: powerpc/fadump: trivial fix of spelling mistake, clean up message 2016-06-27 11:20 ` Michael Ellerman @ 2016-06-27 11:33 ` Joe Perches 2016-06-27 11:34 ` Colin Ian King 1 sibling, 0 replies; 8+ messages in thread From: Joe Perches @ 2016-06-27 11:33 UTC (permalink / raw) To: Michael Ellerman, Colin Ian King, Benjamin Herrenschmidt, Paul Mackerras, Jiri Kosina, Rasmus Villemoes, Andrew Morton, linuxppc-dev Cc: linux-kernel On Mon, 2016-06-27 at 21:20 +1000, Michael Ellerman wrote: > On Mon, 2016-06-27 at 03:51 -0700, Joe Perches wrote: > > > > On Mon, 2016-06-27 at 11:38 +0100, Colin Ian King wrote: > > > > > > On 26/06/16 05:19, Michael Ellerman wrote: > > > > > > > > On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote: > > > > > > > > > > trivial fix to spelling mistake "rgistration" and minor clean up > > > > > of the printk error message > > > > Can you also: > > > > - use pr_err() > > > > - unsplit the message, ie. keep the string all on one line. > > > I can unsplit the string, but checkpatch will complain about that, so > > > I'm not sure if that's preferred or not. > > > > > > WARNING: line over 80 characters > > If the statement is wrapped after the format, > > then checkpatch shouldn't complain. > > > > pr_err("Failed to invalidate firmware-assisted dump registration. Unexpected error (%d).\n", > > rc); > But that's not actually any more readable, so just ignore checkpatch in this > case IMHO. It's a guide, not the gospel. Absolutely. Ignore checkpatch whenever appropriate. There are relatively few lines in kernel source that have printk arguments post format that extend beyond 80 columns though and standardization is also good. cheers back. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: powerpc/fadump: trivial fix of spelling mistake, clean up message 2016-06-27 11:20 ` Michael Ellerman 2016-06-27 11:33 ` Joe Perches @ 2016-06-27 11:34 ` Colin Ian King 2016-06-28 3:50 ` Michael Ellerman 1 sibling, 1 reply; 8+ messages in thread From: Colin Ian King @ 2016-06-27 11:34 UTC (permalink / raw) To: Michael Ellerman, Joe Perches, Benjamin Herrenschmidt, Paul Mackerras, Jiri Kosina, Rasmus Villemoes, Andrew Morton, linuxppc-dev Cc: linux-kernel On 27/06/16 12:20, Michael Ellerman wrote: > On Mon, 2016-06-27 at 03:51 -0700, Joe Perches wrote: >> On Mon, 2016-06-27 at 11:38 +0100, Colin Ian King wrote: >>> On 26/06/16 05:19, Michael Ellerman wrote: >>>> On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote: >>>>> trivial fix to spelling mistake "rgistration" and minor clean up >>>>> of the printk error message >>>> Can you also: >>>> - use pr_err() >>>> - unsplit the message, ie. keep the string all on one line. >>> I can unsplit the string, but checkpatch will complain about that, so >>> I'm not sure if that's preferred or not. >>> >>> WARNING: line over 80 characters >> >> If the statement is wrapped after the format, >> then checkpatch shouldn't complain. >> >> pr_err("Failed to invalidate firmware-assisted dump registration. Unexpected error (%d).\n", >> rc); > > But that's not actually any more readable, so just ignore checkpatch in this > case IMHO. It's a guide, not the gospel. > > cheers > OK, so shall I'll send a V3 w/o the spit and the pr_err fix? ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: powerpc/fadump: trivial fix of spelling mistake, clean up message 2016-06-27 11:34 ` Colin Ian King @ 2016-06-28 3:50 ` Michael Ellerman 0 siblings, 0 replies; 8+ messages in thread From: Michael Ellerman @ 2016-06-28 3:50 UTC (permalink / raw) To: Colin Ian King, Joe Perches, Benjamin Herrenschmidt, Paul Mackerras, Jiri Kosina, Rasmus Villemoes, Andrew Morton, linuxppc-dev Cc: linux-kernel On Mon, 2016-06-27 at 12:34 +0100, Colin Ian King wrote: > On 27/06/16 12:20, Michael Ellerman wrote: > > On Mon, 2016-06-27 at 03:51 -0700, Joe Perches wrote: > > > On Mon, 2016-06-27 at 11:38 +0100, Colin Ian King wrote: > > > > On 26/06/16 05:19, Michael Ellerman wrote: > > > > > On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote: > > > > > > trivial fix to spelling mistake "rgistration" and minor clean up > > > > > > of the printk error message > > > > > Can you also: > > > > > - use pr_err() > > > > > - unsplit the message, ie. keep the string all on one line. > > > > I can unsplit the string, but checkpatch will complain about that, so > > > > I'm not sure if that's preferred or not. > > > > > > > > WARNING: line over 80 characters > > > > > > If the statement is wrapped after the format, > > > then checkpatch shouldn't complain. > > > > > > pr_err("Failed to invalidate firmware-assisted dump registration. Unexpected error (%d).\n", > > > rc); > > > > But that's not actually any more readable, so just ignore checkpatch in this > > case IMHO. It's a guide, not the gospel. > > OK, so shall I'll send a V3 w/o the spit and the pr_err fix? Nah that's fine, I already grabbed v2. cheers ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-06-28 3:50 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-06-24 17:43 [PATCH] powerpc/fadump: trivial fix of spelling mistake, clean up message Colin King 2016-06-26 4:19 ` Michael Ellerman 2016-06-27 10:38 ` Colin Ian King 2016-06-27 10:51 ` Joe Perches 2016-06-27 11:20 ` Michael Ellerman 2016-06-27 11:33 ` Joe Perches 2016-06-27 11:34 ` Colin Ian King 2016-06-28 3:50 ` Michael Ellerman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).