From: xinhui <xinhui.pan@linux.vnet.ibm.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
paulmck@linux.vnet.ibm.com, mingo@redhat.com, mpe@ellerman.id.au,
paulus@samba.org, benh@kernel.crashing.org, Waiman.Long@hpe.com,
boqun.feng@gmail.com, will.deacon@arm.com, dave@stgolabs.net,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH 1/3] kernel/sched: introduce vcpu preempted check interface
Date: Tue, 28 Jun 2016 17:47:07 +0800 [thread overview]
Message-ID: <5772479B.9000600@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160628070013.GC3784@osiris>
On 2016年06月28日 15:00, Heiko Carstens wrote:
> On Mon, Jun 27, 2016 at 04:00:43PM +0200, Peter Zijlstra wrote:
>> On Mon, Jun 27, 2016 at 01:41:28PM -0400, Pan Xinhui wrote:
>>> +++ b/include/linux/sched.h
>>> @@ -3293,6 +3293,15 @@ static inline void set_task_cpu(struct task_struct *p, unsigned int cpu)
>>>
>>> #endif /* CONFIG_SMP */
>>>
>>> +#ifdef arch_vcpu_is_preempted
>>> +static inline bool vcpu_is_preempted(int cpu)
>>> +{
>>> + return arch_vcpu_is_preempted(cpu);
>>> +}
>>> +#else
>>> +#define vcpu_is_preempted(cpu) false
>>> +#endif
>>
>> #ifndef vcpu_is_preempted
>> #define vcpu_is_preempted(cpu) (false)
>> #endif
>>
>> Is so much simpler...
>>
>> Also, please Cc the virt list so that other interested parties can
>> comment, and maybe also the s390 folks.
>
> The s390 implementation would be to simply use cpu_is_preempted() from
> arch/s390/lib/spinlock.c.
that's great.
> It's nice that there will be a common code function for this!
>
next prev parent reply other threads:[~2016-06-28 9:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 17:41 [PATCH 0/3] implement vcpu preempted check Pan Xinhui
2016-06-27 17:41 ` [PATCH 1/3] kernel/sched: introduce vcpu preempted check interface Pan Xinhui
2016-06-27 14:00 ` Peter Zijlstra
2016-06-27 14:02 ` Peter Zijlstra
2016-06-28 3:14 ` xinhui
2016-06-28 7:00 ` Heiko Carstens
2016-06-28 9:47 ` xinhui [this message]
2016-06-27 14:05 ` Boqun Feng
2016-06-28 3:15 ` xinhui
2016-06-27 17:41 ` [PATCH 2/3] powerpc/spinlock: support vcpu preempted check Pan Xinhui
2016-06-27 14:17 ` Peter Zijlstra
2016-06-28 3:23 ` xinhui
2016-06-27 14:58 ` Boqun Feng
2016-06-28 3:39 ` xinhui
2016-06-28 5:03 ` Boqun Feng
2016-06-28 5:38 ` xinhui
2016-06-27 17:41 ` [PATCH 3/3] locking/osq: Drop the overload of osq_lock() Pan Xinhui
2016-06-27 14:21 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5772479B.9000600@linux.vnet.ibm.com \
--to=xinhui.pan@linux.vnet.ibm.com \
--cc=Waiman.Long@hpe.com \
--cc=benh@kernel.crashing.org \
--cc=boqun.feng@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=dave@stgolabs.net \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=schwidefsky@de.ibm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).