From: Daniel Walker <danielwa@cisco.com>
To: Scott Wood <scott.wood@nxp.com>,
Raghav Dogra <raghav.dogra@nxp.com>,
Brian Norris <computersforpeace@gmail.com>,
Jaiprakash Singh <b44839@freescale.com>,
Scott Wood <scottwood@freescale.com>,
Lijun Pan <Lijun.Pan@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"xe-kernel@external.cisco.com" <xe-kernel@external.cisco.com>
Subject: Re: t1040 IFC flash driver Extended Chip Select
Date: Thu, 7 Jul 2016 15:01:16 -0700 [thread overview]
Message-ID: <577ED12C.30105@cisco.com> (raw)
In-Reply-To: <DB5PR0401MB192848637D543D8B95B6092D913B0@DB5PR0401MB1928.eurprd04.prod.outlook.com>
On 07/07/2016 02:59 PM, Scott Wood wrote:
> On 07/07/2016 04:49 PM, Daniel Walker wrote:
>> On 07/07/2016 02:23 PM, Scott Wood wrote:
>>> I suspect that add the usage of cspr_ext into the driver would fix the
>>> issue we have. It reads like you would find that acceptable ?
>>> What specifically is the problem you're having? Is it that CSPR_EXT is
>>> not getting written to, and thus the device does not appear at the
>>> address that it should?
>>>
>>> Or is the driver matching incorrectly? The only way the driver's lack
>>> of using CSPR_EXT to match would be a problem would be if you have
>>> multiple chipselects with the same address in the lower 32 bits, and
>>> only CSPR_EXT distinguishing them. Since you proposed a device tree
>>> binding that assumes all devices have the same CSPR_EXT, I doubt that's
>>> the case, so I doubt adding CSPR_EXT matching to the driver will solve
>>> your problem.
>>>
>>> -Scott
>>>
>> I didn't do the debug on this. From my perspective it's either flash
>> works, or it doesn't work. We need the code below for it to work,
> Adding CSPR_EXT matching to the driver will not accomplish the same
> thing as that code.
>
So from u-boot perspective, the values in the device tree under "ranges"
or parts of it, are place into the cspr and cspr_ext ? Is that how it's
suppose to work ?
Daniel
next prev parent reply other threads:[~2016-07-07 22:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 20:23 t1040 IFC flash driver Extended Chip Select Daniel Walker
2016-07-07 0:57 ` Scott Wood
2016-07-07 15:48 ` Daniel Walker
2016-07-07 19:26 ` Scott Wood
2016-07-07 19:44 ` Daniel Walker
2016-07-07 20:34 ` Scott Wood
2016-07-07 20:52 ` Daniel Walker
2016-07-07 21:23 ` Scott Wood
2016-07-07 21:49 ` Daniel Walker
2016-07-07 21:59 ` Scott Wood
2016-07-07 22:01 ` Daniel Walker [this message]
2016-07-07 22:37 ` Scott Wood
2016-07-07 23:48 ` Daniel Walker
2016-07-09 1:12 ` Scott Wood
2016-07-11 16:36 ` Daniel Walker
2016-07-11 16:55 ` Scott Wood
2016-07-11 17:10 ` Daniel Walker
2016-07-11 18:27 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577ED12C.30105@cisco.com \
--to=danielwa@cisco.com \
--cc=Lijun.Pan@freescale.com \
--cc=b44839@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=raghav.dogra@nxp.com \
--cc=scott.wood@nxp.com \
--cc=scottwood@freescale.com \
--cc=xe-kernel@external.cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).