linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
	Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	anton@ozlabs.org, ananth@in.ibm.com, dja@axtens.net,
	naveen.n.rao@linux.vnet.ibm.com, David.Laight@ACULAB.COM,
	Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Subject: Re: [PATCH v3 3/4] perf annotate: add powerpc support
Date: Wed, 13 Jul 2016 14:59:23 +0530	[thread overview]
Message-ID: <578609F3.5090707@linux.vnet.ibm.com> (raw)
In-Reply-To: <87eg6ym1gq.fsf@@concordia.ellerman.id.au>



On Wednesday 13 July 2016 01:09 PM, Michael Ellerman wrote:
> Arnaldo Carvalho de Melo <acme@kernel.org> writes:
>
>> Em Tue, Jul 12, 2016 at 07:51:46AM +0530, Ravi Bangoria escreveu:
>>> Hi Arnaldo,
>>>
>>> On Friday 08 July 2016 02:01 PM, Michael Ellerman wrote:
>>>> Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> writes:
>>>>
>>>>> On Wednesday 06 July 2016 03:38 PM, Michael Ellerman wrote:
>>>>>
>>>>> I've sent v4 which enables annotate for bctr' instructions.
>>>>>
>>>>> for 'bctr', it will show down arrow(indicate jump) and 'bctrl' will show
>>>>> right arrow(indicate call). But no navigation options will be provided.
>>>>> By pressing Enter key on that, message will be shown that like
>>>>> "Invalid target"
>>>> Great thanks.
>>> I've sent v4 series. Please review it.
>> If somebody else could do it and provide acks/reviewed by, that would
>> help,
>>
>> Michael, can I get your comments as such?
> It looks OK to me. But I don't know the code really, and I haven't had
> time to test it personally.
>
> Ravi, have you tested on a big endian machine?

Yes Michael, I've tested annotate on BE and LE both.

-Ravi

>
> cheers
>

  reply	other threads:[~2016-07-13  9:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-30  6:14 [PATCH v3 0/4] perf annotate: Enable cross arch annotate Ravi Bangoria
2016-06-30  6:14 ` [PATCH v3 1/4] perf: Utility function to fetch arch Ravi Bangoria
2016-06-30  6:14 ` [PATCH v3 2/4] perf annotate: Enable cross arch annotate Ravi Bangoria
2016-06-30  6:14 ` [PATCH v3 3/4] perf annotate: add powerpc support Ravi Bangoria
2016-06-30  6:21   ` Michael Ellerman
2016-07-01  8:43     ` Ravi Bangoria
2016-07-01 12:48       ` Balbir Singh
2016-07-01 13:30         ` Ravi Bangoria
2016-07-05  1:28       ` Ravi Bangoria
2016-07-06 10:08       ` Michael Ellerman
2016-07-08  4:53         ` Ravi Bangoria
2016-07-08  8:31           ` Michael Ellerman
2016-07-12  2:21             ` Ravi Bangoria
2016-07-12  2:39               ` Arnaldo Carvalho de Melo
2016-07-13  7:39                 ` Michael Ellerman
2016-07-13  9:29                   ` Ravi Bangoria [this message]
2016-06-30  6:14 ` [PATCH v3 4/4] perf: Define macro for normalized arch names Ravi Bangoria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=578609F3.5090707@linux.vnet.ibm.com \
    --to=ravi.bangoria@linux.vnet.ibm.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=acme@kernel.org \
    --cc=ananth@in.ibm.com \
    --cc=anton@ozlabs.org \
    --cc=dja@axtens.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).