Re: [PATCH] powerpc/eeh: trivial fix to non-conventional PCI address output on EEH log

["Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>]

On 07/24/2016 09:47 PM, Michael Ellerman wrote:
> "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com> writes:
>
>> This is a very minor/trivial fix for the output of PCI address on EEH logs.
>> The PCI address on "OF node" field currently is using ":" as a separator
>> for the function, but the usual separator is ".". This patch changes the
>> separator for dot, so the PCI address is printed as usual.
>>
>> No functional changes were introduced.
>
> What consumes the log? Can it cope with us changing the formatting?

Michael, as far as I understand (Russel and Gavin surely knows better 
and can correct me if I'm wrong) the only consumer that doesn't just 
output the error information to screen is pseries' get_log handler, 
which will pass this log information through a rtas_call 
(ibm_slot_error_detail).

Now, I imagine this information might be consumed in the end for the 
FSP, by reporting EEH errors there, but my testing in one LPAR showed me 
no errors in FSP after an EEH (without the patch applied). Maybe I'm 
missing a FSP configuration to be able to show the errors there?

Thanks,


Guilherme


>
> cheers
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>