From: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
Gavin Shan <gwshan@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, chzigotzky@xenosoft.de
Subject: Re: [PATCH] powerpc/pci: Only do fixed PHB numbering on powernv
Date: Tue, 9 Aug 2016 08:19:33 -0300 [thread overview]
Message-ID: <57A9BC45.6090904@linux.vnet.ibm.com> (raw)
In-Reply-To: <871t1ysg9w.fsf@concordia.ellerman.id.au>
On 08/09/2016 01:44 AM, Michael Ellerman wrote:
> "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com> writes:
>> On 08/08/2016 09:32 PM, Michael Ellerman wrote:
>>> "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com> writes:
>>>>
>>>> (i) What is the specific issue? Do you have some logs or at least a
>>>> "high-level" description of the problem in Xorg? I took a look in its
>>>> code and PCI domain is coded as u16, which is correct/expected. So it
>>>> seems a subtle bug we should investigate and hopefully fix.
>>>
>>> It was reported here:
>>>
>>> https://lists.ozlabs.org/pipermail/linuxppc-dev/2016-August/147062.html
>>>
>>> It seems xorg just has a hard coded limit of 256 domains.
>>
>> Thanks for the link Michael. I guess Xorg _had_ this limit in the
>> "past", since the function that was logged on error - xf86MapLegacyIO()
>> - was removed by a commit of 2014:
>>
>> https://lists.x.org/archives/xorg-devel/2014-July/043224.html
>
> Aha, nice work.
>
> In fact it seems to be better than that, the array of domains was
> removed in 2011 in:
>
> https://cgit.freedesktop.org/xorg/xserver/commit/?id=858fbbb40d7c69540cd1fb5315cebf811c6e7b3f
>
> Which is officially ancient history as far as I'm concerned.
Heheh great, good finding Michael!
>>>> (ii) Why is it related to the absence of pseries check?! You said this
>>>> was your bad, but as far as I understand, Xorg runs in pSeries too so
>>>> the issue should also be there heheh
>>>
>>> Well yes I guess it would, if anyone had tested Xorg on pseries :)
>>
>> We use to test Xorg on pSeries regularly; in fact, I made a quick test
>> today:
>>
>> http://imgur.com/a/l1lP8
>>
>> I forced the domain to be 0xffff as in the above image, and everything
>> worked fine.
>
> Awesome.
>
>>> I think for now I'm going to apply this, and we'll work out something
>>> else later.
>>
>> OK, I guess your solution is fine and solves the pasemi issue quickly,
>
> No given the above info on xorg I'll drop this, and merge just the
> endian fix.
Perfect, thanks!
> cheers
>
prev parent reply other threads:[~2016-08-09 11:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 6:40 [PATCH] powerpc/pci: Only do fixed PHB numbering on powernv Michael Ellerman
2016-08-07 23:48 ` Gavin Shan
2016-08-08 13:17 ` Guilherme G. Piccoli
2016-08-09 0:32 ` Michael Ellerman
2016-08-09 2:26 ` Guilherme G. Piccoli
2016-08-09 4:44 ` Michael Ellerman
2016-08-09 11:19 ` Guilherme G. Piccoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57A9BC45.6090904@linux.vnet.ibm.com \
--to=gpiccoli@linux.vnet.ibm.com \
--cc=chzigotzky@xenosoft.de \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).